Summary: | multimedia/clipgrab: Update to 3.7.2, Take MAINTAINER'ship | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | kikadf <kikadf.01> | ||||||||||||||
Component: | Individual Port(s) | Assignee: | Tobias Kortkamp <tobik> | ||||||||||||||
Status: | Closed FIXED | ||||||||||||||||
Severity: | Affects Only Me | CC: | meta | ||||||||||||||
Priority: | --- | ||||||||||||||||
Version: | Latest | ||||||||||||||||
Hardware: | Any | ||||||||||||||||
OS: | Any | ||||||||||||||||
URL: | https://reviews.freebsd.org/D17908 | ||||||||||||||||
Bug Depends on: | |||||||||||||||||
Bug Blocks: | 232177 | ||||||||||||||||
Attachments: |
|
Created attachment 197999 [details]
patch v2
Updated to latest 3.7.1 release.
Created attachment 198037 [details]
patch v3 (Qt5 support)
Add Qt5 support and slave port.
(In reply to kikadf from comment #2) I don't not see a slave port in either of the patches. Anyway I think this should be using flavors and not an old-school slave port. -PLIST_FILES= bin/${PORTNAME} \ - %%DATADIR%%/icon.png \ - %%DATADIR%%/logo.png \ - %%DATADIR%%/paypal-logo.png \ - %%DATADIR%%/splash.png This should have been preserved (with maybe %%DATADIR%% -> ${DATADIR}). There is no need for a pkg-plist if the port only installs 5 files. Created attachment 199044 [details] patch v4 (Qt5 support with FLAVORS) The patch of Qt5 slave port is in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=232177, I add that in the blocks section. However I rewrote the patch with FLAVORS. I like FLAVORS stuff ;) Removed the pkg-plist file. Now I should close the clipgrab-qt5 PR, the closed-duplicate of this is the correct close options? (In reply to kikadf from comment #4) > Now I should close the clipgrab-qt5 PR, the closed-duplicate of this is the > correct close options? Use your best judgement. > However I rewrote the patch with FLAVORS. I like FLAVORS stuff ;) > Removed the pkg-plist file. FLAVORS require portmgr approval so it would be good if you put it up on Phabricator (https://reviews.freebsd.org) for review. *** Bug 232177 has been marked as a duplicate of this bug. *** Created attachment 199167 [details] patch v5 Add changes based on review D17908. (Use only Qt5 based clipgrab) Created attachment 199388 [details]
patch v6
Bump version to latest 3.7.2.
Still OK the things.
A commit references this bug: Author: tobik Date: Sun Dec 9 20:03:02 UTC 2018 New revision: 487078 URL: https://svnweb.freebsd.org/changeset/ports/487078 Log: multimedia/clipgrab: Update to 3.7.2 - Add Qt 5 support - Assign new maintainer PR: 231821 Submitted by: kikadf.01@gmail.com (maintainer) Differential Revision: https://reviews.freebsd.org/D17908 Changes: head/multimedia/clipgrab/Makefile head/multimedia/clipgrab/distinfo head/multimedia/clipgrab/pkg-descr |
Created attachment 197630 [details] patch Update to the latest release, fix mastersite, take maintanership. Tested with portlint, ok. Use on amd64 FreeBSD 11.2-RELEASE-p4, works fine.