Bug 231825

Summary: graphics/librsvg2: make_index: Circular dependency loop found: librsvg2-2.40.20 depends upon itself.
Product: Ports & Packages Reporter: Trond.Endrestol
Component: Individual Port(s)Assignee: freebsd-gnome mailing list <gnome>
Status: Closed Overcome By Events    
Severity: Affects Only Me CC: dinoex, jcfyecrayz, lantw44, mi, pi, rm, w.schwarzenfeld
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   

Description Trond.Endrestol 2018-09-30 15:42:01 UTC
After updating to r480954, while running make index this happens:

make_index: Circular dependency loop found: librsvg2-2.40.20 depends upon itself.

Maybe I'm wrong, but I blame r480951 (GNOME 3.28) as I can't find any recent commits specifically for graphics/librsvg2.
Comment 1 Walter Schwarzenfeld freebsd_triage 2018-09-30 16:13:05 UTC
see also:
Comment 2 Ting-Wei Lan 2018-09-30 16:29:17 UTC
(In reply to Trond.Endrestol from comment #0)
This will happen if you have LIBRSVG2 option enabled on graphviz. The GNOME 3.28 update makes librsvg2 depend on vala and vala depend on graphviz.
Comment 3 Ruslan Makhmatkhanov freebsd_committer 2018-09-30 16:57:10 UTC
I'm not yet run-tested, but it looks like graphviz should only go to BUILD_DEPENDS of lang/vala. From vala NEWS file:

  - Merge valadoc - Consider valadoc a part of vala's toolchain and
    therefore let it live in the main repository (adds graphviz to the
Comment 4 Trond.Endrestol 2018-09-30 18:47:19 UTC
The loop was broken by clearing the LIBRSVG2 option on graphics/graphviz. This is the default setting. Removing graphics/graphviz as a runtime dependency of lang/vala makes no difference at all.

Synth's now churning away, rebuilding lang/vala and other outdated ports. We'll know the results in a few hours.
Comment 5 Walter Schwarzenfeld freebsd_triage 2018-09-30 18:51:25 UTC
I think we can set CONFIGURE_ARGS=--disable-vala. I don't know if we 
have also to remove introspection:build (don't know if introspection needs vala).
Comment 6 Ruslan Makhmatkhanov freebsd_committer 2018-09-30 18:58:49 UTC
(In reply to Trond.Endrestol from comment #4)
LIBRSVG2 wasn't and isn't a default option. It's listed in OPTIONS_DEFINE, but not in OPTIONS_DEFAULT, so it looks like your local setting and the problem was triggered by vala update, that added dependency upon graphviz.

Yes, RUN_DEPENDS comment is just about not installing potentially unneeded dependency, not about fixing the dependency loop.
Comment 7 Trond.Endrestol 2018-09-30 21:38:30 UTC
(In reply to Ruslan Makhmatkhanov from comment #6)
I should have chosen my words more carefully.
"The loop was broken free by clearing the LIBRSVG2 option on graphics/graphviz. Which is afterall the default setting."

Anyway, all is well, and I don't think I'll need SVG support in graphviz. PDF output is usually all I use.
Comment 8 Baptiste Daroussin freebsd_committer 2018-10-01 15:11:34 UTC
graphviz does not even need librsvg to produce svg files as by default it just uses cairo.

Imho the right fix is only to nuke the RSVG option from graphviz, it confuses users and causes this new circular dependencies.

Adding dinoex@ in CC as he is the maintainer of graphviz@
Comment 9 Walter Schwarzenfeld freebsd_triage 2018-10-15 17:38:22 UTC
Should solved with ports r482161.
Comment 10 Dirk Meyer freebsd_committer 2018-10-19 17:18:04 UTC
Could you please back out the commit top graphviz,

Neither testing was done before the commit,
neither maintainer approval was given.
Comment 11 John Hein 2018-11-14 01:46:08 UTC
This seems to be at an impasse.  Dirk, what testing needs to be done?
Comment 12 Mikhail T. 2019-01-21 20:37:23 UTC
Related: I just had to uncheck the "SVG" option in graphics/ImageMagick6 in order to solve the "circular dependency" problem reported by portupgrade. lang/vala was the (first) reported duplicate.

Not good...
Comment 13 Walter Schwarzenfeld freebsd_triage 2019-08-28 10:22:59 UTC
Make  index shows no problem. I close here with overcome by events. Reopen it there is still a problem.