Bug 231853
| Summary: | [patch] multimedia/smplayer-skins: rebuild with Qt5, take maintainership | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | kikadf <kikadf.01> | ||||
| Component: | Individual Port(s) | Assignee: | Thomas Zander <riggs> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | riggs | ||||
| Priority: | --- | Keywords: | patch | ||||
| Version: | Latest | Flags: | riggs:
maintainer-feedback+
|
||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Bug Depends on: | 231856 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
Does it make sense to have smplayer-skins use qt5 exclusively? smplayer defaults to qt4 and the toolkit can be set via OPTIONS. For consistent building and packaging, smplayer and smplayer-skins should do the same. (In reply to Thomas Zander from comment #1) I opened a bug to bump smplayer version and use Qt5 as default. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231856 Should I set that bug as depend of this? I opened another smplayer relevant bug too, bump smplayer-themes: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231854 Thanks your review. A commit references this bug: Author: riggs Date: Sun Oct 21 17:35:06 UTC 2018 New revision: 482713 URL: https://svnweb.freebsd.org/changeset/ports/482713 Log: Default toolkit is now QT5, new maintainer PR: 231853 Submitted by: kikadf.01@gmail.com (new maintainer) Changes: head/multimedia/smplayer-skins/Makefile |
Created attachment 197677 [details] patch Take maintainership, rebuild with Qt5 instead of Qt4.