Bug 231870
| Summary: | ports-mgmt/portlint: Bogus warnings about extra items placed in the USES/USE_x section | ||
|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Tobias Kortkamp <tobik> |
| Component: | Individual Port(s) | Assignee: | Joe Marcus Clarke <marcus> |
| Status: | Closed Feedback Timeout | ||
| Severity: | Affects Only Me | ||
| Priority: | --- | ||
| Version: | Latest | ||
| Hardware: | Any | ||
| OS: | Any | ||
| See Also: |
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234527 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=239045 |
||
This is fixed in my CVS repo pending the next release. Fixed in 2.18.5. (In reply to Joe Marcus Clarke from comment #2) Thank you, but this fixes only the USE_GITHUB case. It really was just an example, portlint should also not complain about USE_PYTHON grouped with related variables, for example, USE_PYTHON= ... PYSETUP= ... or USE_WX and related variables, for example, USE_WX= ... WX_COMPS= ... or any other USE_x grouped with related variables. See graphics/py-sk1 or graphics/py-gd for example ports where portlint still just complains about this. Other examples are ports (graphics/gcolor3, textproc/yodl, ...) using USE_GITLAB and the GL_* variables. |
With something like (see editors/ghostwriter for an example port) USES= ... USE_GITHUB= yes GH_ACCOUNT= blabla portlint -AC wrongly complains WARN: Makefile: extra item placed in the USES/USE_x section, for example, "GH_ACCOUNT". 0 fatal errors and 1 warning found. This is contrary to what's suggested in the Porter's Handbook [1] where it says Keep related variables close together. For example, if using USE_GITHUB, always put the GH_* variables right after it. Also see the example Makefile at [2]. [1] https://www.freebsd.org/doc/en/books/porters-handbook/porting-order-uses.html [2] https://www.freebsd.org/doc/en/books/porters-handbook/porting-samplem.html