Bug 231940
| Summary: | multimedia/librtmp : fails to build with openssl 1.1.1 | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Antoine Brodin <antoine> | ||||||||
| Component: | Individual Port(s) | Assignee: | Ben Woods <woodsb02> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Only Me | CC: | andrey, d8zNeCFG, hrs, ndowens04, ohartmann, woodsb02 | ||||||||
| Priority: | --- | Flags: | woodsb02:
maintainer-feedback-
woodsb02: merge-quarterly+ |
||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| URL: | https://github.com/xbmc/inputstream.rtmp/blob/master/depends/common/librtmp/0003-openssl-1.1.patch | ||||||||||
| See Also: |
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=232568 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228939 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=232901 |
||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 231931 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Antoine Brodin
2018-10-04 13:26:13 UTC
Working on this one, should have a patch ready soon Created attachment 197892 [details] Fix openssl 1.1.x build multimedia/librtmp: * Fix OpenSSL 1.1.x build * Removed Makefile patches, fails to apply and no longer needed * Add LICENSE file, while here PR: 231940 Submitted by: Nathan <ndowens@yahoo.com> (In reply to Nathan from comment #2) The DHInit part doesn't look valid to me. Created attachment 197898 [details]
Fix Openssl 1.1.x
Created attachment 197899 [details]
Fix openssl
Bump Commit need Hi Nathan, Am I correct in saying this latest patch you submitted is taken from the GitHub repo here? https://github.com/JudgeZarbi/RTMPDump-OpenSSL-1.1 This compiles ok for me. Cheers, Ben (In reply to Ben Woods from comment #7) If I remember correctly, it was A commit references this bug: Author: woodsb02 Date: Tue Oct 23 11:59:17 UTC 2018 New revision: 482833 URL: https://svnweb.freebsd.org/changeset/ports/482833 Log: multimedia/librtmp: Fix build with OpenSSL 1.1.x - Update LICENSE and add LICENSE_FILE PR: 231940 Submitted by: Nathan <ndowens@yahoo.com> Reported by: antoine Approved by: hrs (maintainer timeout) Obtained from: https://github.com/JudgeZarbi/RTMPDum-OpenSSL-1.1 MFH: 2018Q4 Changes: head/multimedia/librtmp/Makefile head/multimedia/librtmp/files/patch-dh.h head/multimedia/librtmp/files/patch-handshake.h head/multimedia/librtmp/files/patch-hashswf.c Committed - thanks for your submission! Awaiting approval to merge to ports quarterly branch. This broke the build of librtmp consumers: http://package22.nyi.freebsd.org/data/104amd64-default-PR231406/2018-10-23_14h31m17s/logs/errors/rtmpdump-2.4.20151223.log (In reply to Martin Birgmeier from comment #12) Probably just needs some if statements for older , in which I can do later if no one submits before I do A commit references this bug: Author: antoine Date: Tue Oct 23 19:36:42 UTC 2018 New revision: 482870 URL: https://svnweb.freebsd.org/changeset/ports/482870 Log: Revert r482833, it broke librtmp consumers PR: 231940 With hat: portmgr Changes: head/multimedia/librtmp/Makefile head/multimedia/librtmp/files/patch-dh.h head/multimedia/librtmp/files/patch-handshake.h head/multimedia/librtmp/files/patch-hashswf.c *** Bug 232649 has been marked as a duplicate of this bug. *** A commit references this bug: Author: woodsb02 Date: Thu Oct 25 11:54:50 UTC 2018 New revision: 482967 URL: https://svnweb.freebsd.org/changeset/ports/482967 Log: multimedia/librtmp: Fix build with OpenSSL 1.1.x - Update LICENSE and add LICENSE_FILE PR: 231940 Reported by: antoine Approved by: hrs (maintainer timeout) Obtained from: https://github.com/xbmc/inputstream.rtmp/blob/master/depends/common/librtmp/0003-openssl-1.1.patch MFH: 2018Q4 Changes: head/multimedia/librtmp/Makefile head/multimedia/librtmp/files/patch-openssl-1.1 The application of this patch seems to solve the reported issue at least for me on recent 12-STABLE and 13-CURRENT. A commit references this bug: Author: antoine Date: Thu Nov 1 18:13:05 UTC 2018 New revision: 483697 URL: https://svnweb.freebsd.org/changeset/ports/483697 Log: MFH: r482967 multimedia/librtmp: Fix build with OpenSSL 1.1.x - Update LICENSE and add LICENSE_FILE PR: 231940 Reported by: antoine Approved by: hrs (maintainer timeout) Obtained from: https://github.com/xbmc/inputstream.rtmp/blob/master/depends/common/librtmp/0003-openssl-1.1.patch Changes: _U branches/2018Q4/ branches/2018Q4/multimedia/librtmp/Makefile branches/2018Q4/multimedia/librtmp/files/patch-openssl-1.1 Merged to 2018Q4. |