Summary: | irc/irssi : fails to build with openssl 1.1.1 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Antoine Brodin <antoine> | ||||||
Component: | Individual Port(s) | Assignee: | freebsd-ports-bugs (Nobody) <ports-bugs> | ||||||
Status: | Closed FIXED | ||||||||
Severity: | Affects Only Me | CC: | dor.bsd, emaste, ndowens04 | ||||||
Priority: | --- | Flags: | dor.bsd:
maintainer-feedback+
|
||||||
Version: | Latest | ||||||||
Hardware: | Any | ||||||||
OS: | Any | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 231931 | ||||||||
Attachments: |
|
Description
Antoine Brodin
2018-10-05 05:31:06 UTC
I’ll work on this one (In reply to Nathan from comment #1) Have it working now but I got to fix it to where it works on older OpenSSL as well Upstream had worked on this in the past for OpenSSL 1.1.0, https://github.com/irssi/irssi/pull/628/files Was the fix incomplete or did OpenSSL 1.1.1 change things further and break this? Thanks for working on this. Created attachment 197816 [details]
Fix openssl
irc/irssi: * Fix OpenSSL build * Correct order of variables, while here
Fixed it to where it builds on OpenSSL base and OpenSSL devel+ Looks good, thanks! Comment on attachment 197816 [details]
Fix openssl
Approving patch.
The patch doesn't look good to me. Created attachment 197839 [details]
Proposed patch
Proposed patch (untested)
Comment on attachment 197839 [details]
Proposed patch
That should work. Used the changed (configure.ac) on a port that I am also working on and it worked
(In reply to Nathan from comment #10) Tested patch and it does work Antoine A commit references this bug: Author: antoine Date: Sun Oct 14 16:24:08 UTC 2018 New revision: 482051 URL: https://svnweb.freebsd.org/changeset/ports/482051 Log: Fix configure with openssl 1.1.1 PR: 231970 Changes: head/irc/irssi/Makefile head/irc/irssi/files/patch-configure.ac A commit references this bug: Author: antoine Date: Sat Oct 20 05:41:38 UTC 2018 New revision: 482467 URL: https://svnweb.freebsd.org/changeset/ports/482467 Log: MFH: r482051 Fix configure with openssl 1.1.1 PR: 231970 Changes: _U branches/2018Q4/ branches/2018Q4/irc/irssi/Makefile branches/2018Q4/irc/irssi/files/patch-configure.ac |