Bug 231996
| Summary: | [PATCH] net-mgmt/net-snmp: first byte of IF-MIB::ifPhysAddress is always 0 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Yuri Pankov <yuripv> | ||||||
| Component: | Individual Port(s) | Assignee: | Kurt Jaeger <pi> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Some People | CC: | aamiinjimcaale6, pi | ||||||
| Priority: | --- | Flags: | pi:
maintainer-feedback+
|
||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| See Also: | https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=232025 | ||||||||
| Attachments: |
|
||||||||
This should probably be submitted to the upstream developers for net-snmp so that the patches can be included in the source. I'm happy to apply these after they have accepted them. yuri already submitted this upstream: https://sourceforge.net/p/net-snmp/code/merge-requests/20/ net-snmp released 5.8 in August this year, after 4(?) years since 5.7.3. So a new release does not look likely. Kurt, I'm not sure what the net-snmp release schedule has to do with upstream accepting the patch, but, as previously stated, I'll get it committed once they do. yuri, can you test if the problem still persists with net-snmp-5.8 ? There's a patch in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=232025 I checked the 5.8 code, the problem is still there. I checked just to be sure, 1-4 are igb, of which 1,3,4 has physaddr starting with 0 themselves, but igb1 physaddr was set to 'aa:bb:cc:dd:ee:ff' using ifconfig. $ snmpwalk -v 2c -c public localhost IF-MIB::ifTable.1.6 IF-MIB::ifPhysAddress.1 = STRING: 0:25:90:85:4e:98 IF-MIB::ifPhysAddress.2 = STRING: 0:bb:cc:dd:ee:ff IF-MIB::ifPhysAddress.3 = STRING: 0:25:90:85:4e:9a IF-MIB::ifPhysAddress.4 = STRING: 0:25:90:85:4e:9b IF-MIB::ifPhysAddress.5 = STRING: Created attachment 207928 [details]
updated-patch
This patch is updated to work in 5.8. It's already in upstream, but not in 5.8.
Ups, it's not in upstream. A commit references this bug: Author: pi Date: Sun Sep 29 19:41:49 UTC 2019 New revision: 513264 URL: https://svnweb.freebsd.org/changeset/ports/513264 Log: net-mgmt/net-snmp: fix for first byte of IF-MIB::ifPhysAddress is always 0 - netsnmp_arch_interface_container_load() writes terminating NUL directly to the sdl_data *past* the length specified in sdl_nlen, overwriting first byte of physadrr. PR: 231996 Submitted by: Yuri Pankov <yuripv@yuripv.net> Reviewed by: Bart Van Assche <bvanassche@acm.org> (upstream maintainer) Approved by: zi (maintainer) Obtained from: https://sourceforge.net/p/net-snmp/code/merge-requests/20/ Changes: head/net-mgmt/net-snmp/files/patch-agent_mibgroup_if-mib_data__access_interface__sysctl.c Committed as merged by upstream, thanks! MARKED AS SPAM |
Created attachment 197828 [details] use temporary copy for if_name netsnmp_arch_interface_container_load() writes terminating NUL directly to the sdl_data *past* the length specified in sdl_nlen, overwriting first byte of physadrr.