Bug 232016
| Summary: | games/nxengine: fix build with powerpc64 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Piotr Kubaj <pkubaj> | ||||
| Component: | Individual Port(s) | Assignee: | Nikolai Lifanov <lifanov> | ||||
| Status: | Closed Overcome By Events | ||||||
| Severity: | Affects Only Me | CC: | linimon, pkubaj | ||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(lifanov) |
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
I don't have powerpc64 hardware to test on, but the fix seems reasonable. I'm going to commit it as-is. Actually, I'm going to appy the same fix for everything. aarch64, armv6, and armv7 are broken in the same way. A commit references this bug: Author: lifanov Date: Mon Oct 15 00:13:06 UTC 2018 New revision: 482126 URL: https://svnweb.freebsd.org/changeset/ports/482126 Log: unbreak games/nxengine on powerpc64 and others PR: 232016 Submitted by: Piotr Kubaj Changes: head/games/nxengine/Makefile I made the CXXFLAGS addition global to also unbreak arm platforms. Committed, thanks! Could you replace -Wno-error-narrowing with -Wno-error=narrowing? The former is not supported by GCC, the latter is supported by both Clang and GCC. |
Created attachment 197851 [details] patch Building this port on powerpc64 currently fails with: /tmp/usr/local/poudriere/ports/default/games/nxengine/work/nxengine-evo-2.6.3/src/player.cpp:763:53: error: narrowing conversion of '-1' from 'int' to 'char' i nside { } [-Wnarrowing] { LEFTKEY, RIGHTKEY, UPKEY, JUMPKEY, FIREKEY, -1 }; ^ Fix this by adding -Wno-error=narrowing to CXXFLAGS for powerpc64. Hardware sponsored by IntegriCloud.