Bug 232086

Summary: net/tcpflow: fix build with GCC-based architectures
Product: Ports & Packages Reporter: Piotr Kubaj <pkubaj>
Component: Individual Port(s)Assignee: Antoine Brodin <antoine>
Status: Closed Not Accepted    
Severity: Affects Only Me CC: linimon, pkubaj
Priority: --- Flags: bugzilla: maintainer-feedback? (antoine)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch none

Description Piotr Kubaj freebsd_committer freebsd_triage 2018-10-08 20:52:12 UTC 
Created attachment 197929 [details]
patch

This port requires USES=compiler:c11 to build on architectures using GCC in base.

It also requires including sys/param.h in src/wifipcap/wifipcap.cpp.

Tested on powerpc64 and amd64.

Hardware sponsored by IntegriCloud.
Comment 1 Antoine Brodin freebsd_committer freebsd_triage 2018-10-09 19:34:01 UTC 
Please send the patch upstream,  I don't want to keeps patches around for archs I can't test on.
Comment 2 Piotr Kubaj freebsd_committer freebsd_triage 2018-10-09 20:37:02 UTC 
(In reply to Antoine Brodin from comment #1)
You don't need to test it on tier 2 architectures. You can just build with GCC on amd64 using by defining USE_GCC=yes.
Comment 3 Antoine Brodin freebsd_committer freebsd_triage 2018-10-09 20:38:38 UTC 
Please send the patch upstream,  I don't want to keep patches around.
Comment 4 Piotr Kubaj freebsd_committer freebsd_triage 2018-10-09 20:49:58 UTC 
https://github.com/simsong/tcpflow/pull/193
Comment 5 Antoine Brodin freebsd_committer freebsd_triage 2018-10-28 09:53:01 UTC 
This will be picked up when this goes upstream.