Bug 232144

Summary: net/ipdecap: Fix OpenSSL build
Product: Ports & Packages Reporter: Nathan <ndowens04>
Component: Individual Port(s)Assignee: freebsd-ports-bugs mailing list <ports-bugs>
Status: Closed FIXED    
Severity: Affects Only Me CC: loic-freebsd, swills
Priority: --- Flags: bugzilla: maintainer-feedback? (loic-freebsd)
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://github.com/lpefferkorn/ipdecap/commit/02e435fa9ca2ccaef4eb81033adc0249c786ffea#diff-c2f7614dfa8653e0e2263ef3f20e725d
Bug Depends on:    
Bug Blocks: 231931    
Attachments:
Description Flags
Fix openssl
none
Fix openssl
none
Fix ssl
none
Fix ssl none

Description Nathan 2018-10-10 02:42:49 UTC
net/ipdecap: Fix OpenSSL build                                                                        PR:             231931                             Submitted by:   Nathan <ndowens@yahoo.com>
Comment 1 Nathan 2018-10-10 02:45:08 UTC
Created attachment 197992 [details]
Fix openssl
Comment 2 Antoine Brodin freebsd_committer 2018-10-10 06:01:52 UTC
This doesn't look good,  EVP_CIPHER_CTX_init is used on uninitialized memory.
Comment 3 Nathan 2018-10-10 06:29:08 UTC
Created attachment 197993 [details]
Fix openssl

Match upstreams changes
Comment 4 Nathan 2018-10-10 06:37:12 UTC
Created attachment 197994 [details]
Fix ssl

Fix missed code change
Comment 5 Nathan 2018-10-10 06:47:48 UTC
Created attachment 197995 [details]
Fix ssl

Sorry for the pings  this should be last at this time
Comment 6 loic-freebsd 2018-10-10 20:12:39 UTC
Hello,

Thanks for looking at this!
What about updating the port to the latest 0.7.2 upstream version instead, which includes the openssl fix?

https://loicpefferkorn.net/ipdecap/ipdecap-0.7.2.tar.gz

I wasn't able to find the time to do it so far, but I'll try to find some time this week-end if this has not been done before.

Kind regards,
Loic
Comment 7 Nathan 2018-10-10 21:23:49 UTC
(In reply to loic-freebsd from comment #6)
New version doesn't compile. But I can for the moment use fixes to patch current version in ports
Comment 8 loic-freebsd 2018-10-10 21:33:09 UTC
(In reply to Nathan from comment #7)

I am ok with the patch then. I will investigate the latest version build error this week-end.
Comment 9 loic-freebsd 2018-10-13 11:29:37 UTC
I've submitted a patch to update to 0.7.2 and fix the build issue at the same time: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=232223
Comment 10 Steve Wills freebsd_committer 2018-10-14 19:06:54 UTC
Fixed in r482107