Bug 232216

Summary: sysutils/dmg2img: Fix OpenSSL build
Product: Ports & Packages Reporter: Nathan <ndowens04>
Component: Individual Port(s)Assignee: Po-Chuan Hsieh <sunpoet>
Status: Closed FIXED    
Severity: Affects Only Me CC: ndowens04, sunpoet, tobik
Priority: --- Flags: bugzilla: maintainer-feedback? (sunpoet)
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://sources.debian.org/patches/dmg2img/1.6.7-1/
Bug Depends on:    
Bug Blocks: 231931    
Attachments:
Description Flags
OpenSSL patch ndowens04: maintainer-approval? (sunpoet)

Description Nathan 2018-10-13 04:22:16 UTC 
Created attachment 198086 [details]
OpenSSL patch

sysutils/dmg2img: Fix OpenSSL build
 
 PR:             231931
 Submitted by:   Nathan <ndowens@yahoo.com>
Comment 1 Tobias Kortkamp freebsd_committer freebsd_triage 2018-10-13 06:59:07 UTC 
This seems ok-ish after a quick read.  The code could use some NULL checks
to check if the *_new() functions actually returned something usable though...
Comment 2 Po-Chuan Hsieh freebsd_committer freebsd_triage 2018-10-20 08:16:51 UTC 
Thanks for submitting a patch. But I think this patch is incomplete. At least it cannot be applied directly. Otherwise, it would make the port fails to build with base OpenSSL of FreeBSD 11 (1.0.2*).

I've committed a patch in r482053. Please reopen this PR if it does not work. Thanks!