Bug 232246

Summary: devel/py-oslo.messaging: Fix for the RabbitMQ driver when used with Python 3+
Product: Ports & Packages Reporter: Kai Knoblich <kai>
Component: Individual Port(s)Assignee: Po-Chuan Hsieh <sunpoet>
Status: Closed FIXED    
Severity: Affects Only Me CC: python, sunpoet
Priority: --- Flags: bugzilla: maintainer-feedback? (sunpoet)
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on:    
Bug Blocks: 232244, 232245    
Attachments:
Description Flags
py-oslo.messaging-fix-rabbitmq-py36.patch
kai: maintainer-approval? (sunpoet)
py-oslo.messaging-fix-rabbitmq-py36.log none

Description Kai Knoblich freebsd_committer freebsd_triage 2018-10-14 13:07:22 UTC 
Created attachment 198134 [details]
py-oslo.messaging-fix-rabbitmq-py36.patch

Hello,

attached is the patch that fixes the RabbitMQ driver (= oslo_messaging/_drivers/impl_rabbit.py) on FreeBSD when used as Python 3+ package.

Without the patch the RabbitMQ messaging driver tries to use a timeout for a newly created TCP socket but will fail shortly afterwards because FreeBSD doesn't implement the TCP_USER_TIMEOUT option (RFC 5482) (yet?).

This leads into spawning multiple embryonic TCP connections that are never going into the ESTABLISHED state. 

The issue has been discovered during runtime-tests of the misc/py-cinder port in conjunction with a RabbitMQ messaging server. Please see also the attached logfile for further details.

QA:
~~~
- poudriere (10.4-, 11.2-RELEASE, 12.0-ALPHA9 amd64 + i386) for each py27 + py36 flavor -> OK
- portlint -> OK
Comment 1 Kai Knoblich freebsd_committer freebsd_triage 2018-10-14 13:09:02 UTC 
Created attachment 198135 [details]
py-oslo.messaging-fix-rabbitmq-py36.log
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-10-16 20:06:36 UTC 
A commit references this bug:

Author: sunpoet
Date: Tue Oct 16 20:05:52 UTC 2018
New revision: 482259
URL: https://svnweb.freebsd.org/changeset/ports/482259

Log:
  Fix RabbitMQ connections with Python 3.x

  - Bump PORTREVISION for package change

  PR:		232246
  Submitted by:	Kai <freebsd_ports@k-worx.org>

Changes:
  head/devel/py-oslo.messaging/Makefile
  head/devel/py-oslo.messaging/files/
  head/devel/py-oslo.messaging/files/patch-oslo_messaging-_drivers-impl_rabbit.py
Comment 3 Po-Chuan Hsieh freebsd_committer freebsd_triage 2018-10-16 20:07:24 UTC 
Committed. Thanks!