Bug 232251
| Summary: | sysutils/hstr: update to 2.0 | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Patrice Clement <monsieurp> | ||||||||||
| Component: | Individual Port(s) | Assignee: | Fernando Apesteguía <fernape> | ||||||||||
| Status: | Closed FIXED | ||||||||||||
| Severity: | Affects Only Me | CC: | fernape, swills | ||||||||||
| Priority: | --- | ||||||||||||
| Version: | Latest | ||||||||||||
| Hardware: | Any | ||||||||||||
| OS: | Any | ||||||||||||
| Attachments: |
|
||||||||||||
Created attachment 198148 [details]
hstr-2.0.diff
I've reworked a bit the Makefile. Here's the result.
(In reply to Patrice Clement from comment #1) Patch needs to include update to distinfo Created attachment 199214 [details]
hstr-2.0.diff
Sorry for not responding quicker. Here's the correct diff. Cheers.
Hi Patrice, Thanks for the patch! A couple of things: * portlint -AC warns about using spaces instead of tabs in the Makefile (corrected) * We don't need PORTREVISION if we are bumping PORTVERSION * The bash-completion file was missing from PLIST_FILES * There's a missing dependency on pkg-config Would you use portlint and poudriere/synth? They're great tools that catch most of these things :) Also, is there any reason to deactivate the -O2 flag? I compiled and run tested it and seems to work perfectly fine. I think we can get rid of the patch in files/ I attached a new version for the patch. How does it look to you? Created attachment 199392 [details]
v2 for the update to 2.0
Hi Fernando Thanks for the tips. I'm not familiar with the arsenal of tools on FreeBSD at my disposal to contribute better patches yet. Your patch looks good to me. Feel free to commit it as is. Thanks again! :) PS: I'd like to contribute more patches to FreeBSD. Do you have any pointer as to where I could look for bugs? Thanks. (In reply to Patrice Clement from comment #6) No worries! Just have a look at some of the tools :-) I'll go ahead with the patch. If you want to look for bugs, this is the place, just hit the search button and apply filters if you are interested in something in particular. A commit references this bug: Author: fernape Date: Wed Nov 21 17:17:07 UTC 2018 New revision: 485524 URL: https://svnweb.freebsd.org/changeset/ports/485524 Log: sysutils/hstr: update to 2.0 Announcement: https://github.com/dvorka/hstr/releases/tag/2.0 PR: 232251 Submitted by: monsieurp@gentoo.org (maintainer) Changes: head/sysutils/hstr/Makefile head/sysutils/hstr/distinfo head/sysutils/hstr/files/ Committed, Thanks! |
Created attachment 198142 [details] hstr-2.0.diff Hi Here's the diff to update hstr to version 2.0. Cheers