Bug 232298

Summary: graphics/graphviz: pkg-plist not updated after removing option LIBRSVG2
Product: Ports & Packages Reporter: Rainer Hurling <rhurlin>
Component: Individual Port(s)Assignee: Antoine Brodin <antoine>
Status: Closed FIXED    
Severity: Affects Only Me CC: dinoex, jrm, mat, rhurlin, vrwmiller, w.schwarzenfeld
Priority: --- Keywords: regression
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch to correct pkg-plist of graphics/graphviz
none
patch to fix pkg-plist issue jrm: maintainer-approval?

Description Rainer Hurling freebsd_committer freebsd_triage 2018-10-15 19:13:42 UTC
Created attachment 198187 [details]
patch to correct pkg-plist of graphics/graphviz

graphics/graphviz fails to install after r482161, because option variable LIBRSVG2 was not removed from pkg-plist.

The appended patch should correct this.

Builds fine for me on 12-ALPHA9 amd64.


---
'portlint -AC' complains about several issues, which I did not correct with this patch:

WARN: Makefile: [149]: possible direct use of command "ruby" found. use ${RUBY} instead.
WARN: Makefile: [141]: possible direct use of command "perl" found. use ${PERL} instead.
WARN: Makefile: [146]: possible direct use of command "python" found. use ${PYTHON_CMD} instead.
WARN: Makefile: possible use of absolute pathname "/nonexistent".
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
WARN: Makefile: new ports should not set PORTREVISION.
WARN: Makefile: extra item placed in the USES/USE_x section, for example, "GNU_CONFIGURE".
WARN: Makefile: "BROKEN" has to appear earlier.
WARN: Makefile: no port directory /usr/ports/lang/tcl found, even though it is listed in BUILD_DEPENDS.
WARN: Consider to set DEVELOPER=yes in /etc/make.conf
10 warnings found.
Comment 1 Walter Schwarzenfeld 2018-10-15 19:17:03 UTC
Added the committer of port r482161 to CC-List.
Comment 2 Walter Schwarzenfeld 2018-10-15 19:17:53 UTC
ports r482161.
Comment 3 Joseph Mingrone freebsd_committer freebsd_triage 2018-10-16 02:54:06 UTC
Created attachment 198194 [details]
patch to fix pkg-plist issue

The first patch gives:
===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: lib/graphviz/libgvplugin_rsvg.la
Error: Missing: lib/graphviz/libgvplugin_rsvg.so
Error: Missing: lib/graphviz/libgvplugin_rsvg.so.6
Error: Missing: lib/graphviz/libgvplugin_rsvg.so.6.0.0
===> Error: Plist issues found.

With the second patch, the build completes successfully.

Adding mat@, who committed the change that removed the LIBRSVG2 option.
Comment 4 Rainer Hurling freebsd_committer freebsd_triage 2018-10-16 04:58:31 UTC
(In reply to Joseph Mingrone from comment #3)

I am bit irritated, because these lines in pkg-plist are needed on my boxes, and took a deeper look.


In the commit message r482161 from mat he says:
Remove LIBRSVG2 option, it creates a dependency loop.
It is also discouraged upstream, graphviz can create svg without it.


For me, this sound like mat was trying to use svg functionality, but without an option.

As far, as I understand graphics/graphviz, it has to use graphics/librsvg2 to get svg functionality, see configure script. One can set --with-rsvg=no, if svg should be disabled. 

Otherwise it depends on the presence of graphics/librsvg2, if rsvg can be built. So it needs the presence of something like 'USE=   GNOME=librsvg2 GL=gl,glu,glut' and option PANGOCAIRO enabled.

If I am right, then there is no svg functionality available within graphviz without librsvg2 and cairo.
Comment 5 Joseph Mingrone freebsd_committer freebsd_triage 2018-10-16 09:06:27 UTC
I will guess that you were testing outside of poudriere and some auto-detection was used by the build and those libraries were built.  In any case, tobik's commit in r482210 hopefully fixes this.
Comment 6 Walter Schwarzenfeld 2018-10-16 10:51:38 UTC
Is fixed with ports r482203.
Comment 7 Rainer Hurling freebsd_committer freebsd_triage 2018-10-16 10:56:21 UTC
(In reply to Joseph Mingrone from comment #5)

Yes, of course, tested outside Poudriere. This was for the scenario, when a normal user wants to install graphics/graphviz from sources via Portmaster and get different versions, dependend on graphics/librsvg2 installed or not.

Fine, now with your newest patch, graphviz behaves same, with and witout librsvg2 installed. Many thanks.
Comment 8 Tobias Kortkamp freebsd_committer freebsd_triage 2018-10-16 11:53:25 UTC
*** Bug 232317 has been marked as a duplicate of this bug. ***
Comment 9 Kubilay Kocak freebsd_committer freebsd_triage 2018-10-17 05:01:35 UTC
Assign to committer that resolved