Bug 232362

Comment 1 Hans Petter Selasky 2018-10-18 11:54:13 UTC

Some related issues?

https://svnweb.freebsd.org/changeset/base/339358

https://reviews.freebsd.org/D17598
https://reviews.freebsd.org/D17599

--HPS

The problem seems to be iflib/igb specific, I guess.
Using if_lagg(4) as parent with one USB ethernet (axge(4)/ue) port doesn't crash the system!
Manually configuring a if_vlan(4) child on a if_lagg(4) parent with a if_igb(4) port also leads to a panic, like when rc(8) is doing it.  I tested with i210 and 82576.

Here's the i210 backtrace:
panic: sleeping in an epoch section
cpuid = 2
time = 1539941673
KDB: stack backtrace:
db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xffffffff819e2360
vpanic() at vpanic+0x1a3/frame 0xffffffff819e23c0
panic() at panic+0x43/frame 0xffffffff819e2420
_sleep() at _sleep+0x456/frame 0xffffffff819e24c0
pause_sbt() at pause_sbt+0x11f/frame 0xffffffff819e2500
e1000_reset_hw_82580() at e1000_reset_hw_82580+0x1d6/frame 0xffffffff819e2540
em_if_stop() at em_if_stop+0x1b/frame 0xffffffff819e2560
iflib_stop() at iflib_stop+0xb1/frame 0xffffffff819e25b0
iflib_vlan_register() at iflib_vlan_register+0xad/frame 0xffffffff819e25f0
lagg_register_vlan() at lagg_register_vlan+0xda/frame 0xffffffff819e2650
vlan_config() at vlan_config+0x51e/frame 0xffffffff819e26b0
vlan_ioctl() at vlan_ioctl+0x32e/frame 0xffffffff819e2710
ifhwioctl() at ifhwioctl+0x20e/frame 0xffffffff819e2790
ifioctl() at ifioctl+0x757/frame 0xffffffff819e2850
kern_ioctl() at kern_ioctl+0x2ba/frame 0xffffffff819e28b0
sys_ioctl() at sys_ioctl+0x16a/frame 0xffffffff819e2980
amd64_syscall() at amd64_syscall+0x28c/frame 0xffffffff819e2ab0
fast_syscall_common() at fast_syscall_common+0x101/frame 0xffffffff819e2ab0
--- syscall (54, FreeBSD ELF64, sys_ioctl), rip = 0x800485f6a, rsp = 0x7fffffffe0e8, rbp = 0x7fffffffe120 ---
KDB: enter: panic
#5  0xffffffff807b7aa3 in kdb_trap (type=3, code=0, tf=<value optimized out>)
    at /usr/local/share/deploy-tools/HEAD/src/sys/kern/subr_kdb.c:693
#6  0xffffffff80adef00 in trap (frame=0xffffffff819e2290) at /usr/local/share/deploy-tools/HEAD/src/sys/amd64/amd64/trap.c:619
#7  0xffffffff80ab8915 in calltrap () at /usr/local/share/deploy-tools/HEAD/src/sys/amd64/amd64/exception.S:232
#8  0xffffffff807b717b in kdb_enter (why=0xffffffff80c25469 "panic", msg=<value optimized out>) at cpufunc.h:65
#9  0xffffffff80770670 in vpanic (fmt=<value optimized out>, ap=0xffffffff819e2400)
    at /usr/local/share/deploy-tools/HEAD/src/sys/kern/kern_shutdown.c:861
#10 0xffffffff80770413 in panic (fmt=<value optimized out>)
    at /usr/local/share/deploy-tools/HEAD/src/sys/kern/kern_shutdown.c:799
#11 0xffffffff8077b256 in _sleep (ident=0xffffffff81101762, lock=0x0, priority=0, wmesg=0xc5 <Address 0xc5 out of bounds>, 
    sbt=<value optimized out>, pr=-2136234978, flags=256) at /usr/local/share/deploy-tools/HEAD/src/sys/kern/kern_synch.c:150
#12 0xffffffff8077b65f in pause_sbt (wmesg=<value optimized out>, sbt=42949670, pr=<value optimized out>, 
    flags=<value optimized out>) at /usr/local/share/deploy-tools/HEAD/src/sys/kern/kern_synch.c:332
#13 0xffffffff80558516 in e1000_reset_hw_82580 (hw=0xffffffff81b84008) at e1000_osdep.h:97
#14 0xffffffff8054014b in em_if_stop (ctx=<value optimized out>)
    at /usr/local/share/deploy-tools/HEAD/src/sys/dev/e1000/if_em.c:1842
#15 0xffffffff80896b01 in iflib_stop (ctx=0xfffff80002b52c00) at ifdi_if.h:268
#16 0xffffffff808a41ad in iflib_vlan_register (arg=0xfffff80002b52c00, ifp=0xfffff80002a9e000, vtag=232)
    at /usr/local/share/deploy-tools/HEAD/src/sys/net/iflib.c:3949
#17 0xffffffff8088a7ea in lagg_register_vlan (arg=<value optimized out>, ifp=<value optimized out>, vtag=<value optimized out>)
    at /usr/local/share/deploy-tools/HEAD/src/sys/net/if_lagg.c:451
#18 0xffffffff8089600e in vlan_config (ifv=0xfffff800150f4180, p=0xfffff80002a25000, vid=<value optimized out>)
    at /usr/local/share/deploy-tools/HEAD/src/sys/net/if_vlan.c:1439
#19 0xffffffff8089579e in vlan_ioctl (ifp=<value optimized out>, cmd=<value optimized out>, data=0xffffffff819e28d0 "lagg1egn")
    at /usr/local/share/deploy-tools/HEAD/src/sys/net/if_vlan.c:1828
#20 0xffffffff8087640e in ifhwioctl (cmd=2149607737, ifp=<value optimized out>, data=0xffffffff819e28d0 "lagg1egn", 
    td=0xfffff80015496000) at /usr/local/share/deploy-tools/HEAD/src/sys/net/if.c:2861
#21 0xffffffff808782a7 in ifioctl (so=0xfffff8001580ca38, cmd=2149607737, data=<value optimized out>, td=0xfffff80015496000)
    at /usr/local/share/deploy-tools/HEAD/src/sys/net/if.c:3081
#22 0xffffffff807dc82a in kern_ioctl (td=0xfffff80015496000, fd=3, com=<value optimized out>, data=<value optimized out>)
    at file.h:330
#23 0xffffffff807dc4ea in sys_ioctl (td=0xfffff80015496000, uap=0xfffff800154963c0)
---Type <return> to continue, or q <return> to quit---
    at /usr/local/share/deploy-tools/HEAD/src/sys/kern/sys_generic.c:712
#24 0xffffffff80adfd7c in amd64_syscall (td=0xfffff80015496000, traced=0) at subr_syscall.c:135
#25 0xffffffff80ab91fd in fast_syscall_common () at /usr/local/share/deploy-tools/HEAD/src/sys/amd64/amd64/exception.S:504
#26 0x0000000800485f6a in ?? ()

I don't think this will be fixable with a one liner...
Can somebody with more knowledge estimate when this can be fixed? Hopefully before 12.0-RELEASE?
I don't have any other NICs available for testing, like bnxt(4), which is also iflib based.  Can somebody with mlx4en(4) or cxgb(4) check? I guess these are non-iflib based NICs.

Thanks,
-harry

Just a short note that r339547 (vlan: Fix panic with lagg and vlan) doesn't influence this problem and, like expected, hasn't changed the panic (locally merged to 12-stable).
Likewise r339587 (Resolve deadlock between epoch(9) and various network interface SX-locks,).

Tell me if I can provide more info.

-harry

*** This bug has been marked as a duplicate of bug 240609 ***