Summary: | [patch] join: bug when input does not contain enough columns for the comparison column | ||
---|---|---|---|
Product: | Base System | Reporter: | Conrad Meyer <cem> |
Component: | bin | Assignee: | Tijl Coosemans <tijl> |
Status: | Closed FIXED | ||
Severity: | Affects Only Me | CC: | rootkea, tijl |
Priority: | --- | Keywords: | patch |
Version: | CURRENT | ||
Hardware: | Any | ||
OS: | Any |
Description
Conrad Meyer
2018-10-18 18:35:57 UTC
Adding a reference to the bug and patch mentioned in above comment: https://marc.info/?l=openbsd-tech&m=153987435602410 One also gets hit by this bug if one of the file contains blank lines: ``` $ cat 1.txt a b $ cat 2.txt a b $ join 1.txt 2.txt $ ``` Conrad can you commit this? Also reported here: https://lists.gnu.org/archive/html/bug-gnulib/2024-01/msg00028.html (In reply to Tijl Coosemans from comment #2) No, but you should feel free. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=95bf75895ddcf17402b1f69dce26cb821c922476 commit 95bf75895ddcf17402b1f69dce26cb821c922476 Author: Tijl Coosemans <tijl@FreeBSD.org> AuthorDate: 2024-01-22 10:35:31 +0000 Commit: Tijl Coosemans <tijl@FreeBSD.org> CommitDate: 2024-01-24 09:58:00 +0000 join(1): Fix ordering in case of missing fields The comparison function had the ordering reversed causing join(1) to miss some matching lines. PR: 232405 Submitted by: Martijn van Duren <martijn@openbsd.org> MFC after: 1 week usr.bin/join/join.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) A commit in branch stable/14 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=aaefd6898a73528d3888331a51983cbcc9f06125 commit aaefd6898a73528d3888331a51983cbcc9f06125 Author: Tijl Coosemans <tijl@FreeBSD.org> AuthorDate: 2024-01-22 10:35:31 +0000 Commit: Tijl Coosemans <tijl@FreeBSD.org> CommitDate: 2024-01-31 08:53:11 +0000 join(1): Fix ordering in case of missing fields The comparison function had the ordering reversed causing join(1) to miss some matching lines. PR: 232405 Submitted by: Martijn van Duren <martijn@openbsd.org> (cherry picked from commit 95bf75895ddcf17402b1f69dce26cb821c922476) usr.bin/join/join.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) A commit in branch stable/13 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=085ab2c143eb5192ea18b8dd52bd8fa69c9f2d06 commit 085ab2c143eb5192ea18b8dd52bd8fa69c9f2d06 Author: Tijl Coosemans <tijl@FreeBSD.org> AuthorDate: 2024-01-22 10:35:31 +0000 Commit: Tijl Coosemans <tijl@FreeBSD.org> CommitDate: 2024-01-31 09:19:00 +0000 join(1): Fix ordering in case of missing fields The comparison function had the ordering reversed causing join(1) to miss some matching lines. PR: 232405 Submitted by: Martijn van Duren <martijn@openbsd.org> (cherry picked from commit 95bf75895ddcf17402b1f69dce26cb821c922476) usr.bin/join/join.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) |