Bug 232526

Summary: net/bctoolbox: fix build with GCC-based architectures
Product: Ports & Packages Reporter: Piotr Kubaj <pkubaj>
Component: Individual Port(s)Assignee: Tijl Coosemans <tijl>
Status: Closed FIXED    
Severity: Affects Only Me CC: linimon, ndowens04
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch none

Description Piotr Kubaj freebsd_committer freebsd_triage 2018-10-22 11:52:31 UTC
Created attachment 198461 [details]
patch

Add USES=compiler:c++11-lang to fix build with GCC architectures.

Tested on powerpc64 and amd64.

Hardware sponsored by IntegriCloud.
Comment 1 Nathan 2018-10-22 16:45:29 UTC
As I’ve mentioned before adding compiler:c* breaks mips and also adds unneeded dep in gcc when not needed. You need to target only the arch’s that need the compiler instead of adding unnecessary deps and break archs that can’t use gcc
Comment 2 Piotr Kubaj freebsd_committer freebsd_triage 2018-10-22 16:56:37 UTC
(In reply to Nathan from comment #1)
This port fail without C++11:
https://talos.anongoth.pl/data/powerpc64-default/2018-10-21_19h31m54s/logs/errors/bctoolbox-0.6.0.log
Comment 3 Nathan 2018-10-22 16:57:55 UTC
(In reply to Piotr Kubaj from comment #2)
You can still target ones that need it and not all. I showed you how in previous bugs you’ve reported
Comment 4 Piotr Kubaj freebsd_committer freebsd_triage 2018-10-22 17:01:02 UTC
(In reply to Nathan from comment #3)
Do you think C++11 is used only by some architectures?

This is NOT a compiler bug that makes only some architectures fail, this is a lack of functionality that also exists on other architectures:
(00:03:46) CMake Error in src/CMakeLists.txt:
(00:03:46)   Target "bctoolbox" requires the language dialect "CXX11" (with compiler
(00:03:46)   extensions), but CMake does not know the compile flags to use to enable it.
Comment 5 commit-hook freebsd_committer freebsd_triage 2018-10-22 19:24:29 UTC
A commit references this bug:

Author: tijl
Date: Mon Oct 22 19:23:54 UTC 2018
New revision: 482777
URL: https://svnweb.freebsd.org/changeset/ports/482777

Log:
  Add USES=compiler:c++11-lib to Linphone ports.

  PR:		232526
  Submitted by:	pkubaj@anongoth.pl

Changes:
  head/deskutils/belcard/Makefile
  head/multimedia/mswebrtc/Makefile
  head/net/bctoolbox/Makefile
  head/net/liblinphone/Makefile
  head/net/linphone/Makefile
  head/textproc/belr/Makefile