Bug 232690
| Summary: | New port: devel/pmdk: a collection of libraries and tools for System Administrators and Application Developers | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | D Scott Phillips <d.scott.phillips> | ||||||
| Component: | Individual Port(s) | Assignee: | Mateusz Piotrowski <0mp> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | 0mp, ndowens04 | ||||||
| Priority: | --- | Keywords: | patch | ||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
|
Description
D Scott Phillips
2018-10-25 20:02:32 UTC
Comment on attachment 198630 [details] 0001-New-port-devel-pmdk.patch +BUILD_DEPENDS= autoconf:devel/autoconf Change to USES= autoreconf:build Could simplify: + ${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/libpmem.so.1.0.0 + ${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/libpmemblk.so.1.0.0 + ${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/libpmemcto.so.1.0.0 + ${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/libpmemlog.so.1.0.0 + ${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/libpmemobj.so.1.0.0 + ${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/libpmempool.so.1.0.0 + ${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/libvmem.so.1.0.0 + ${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/libvmmalloc.so.1.0.0 ${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/*.so.1.0.0 Also USES goes after *_DEPENDS https://www.freebsd.org/doc/en/books/porters-handbook/porting-order.html So should be: +BUILD_DEPENDS= autoconf:devel/autoconf +BUILD_DEPENDS+= bash:shells/bash +BUILD_DEPENDS+= doxygen:devel/doxygen + +LIB_DEPENDS= libuuid.so:misc/e2fsprogs-libuuid +USES= gmake pkgconfig +USE_GITHUB= YES +GH_ACCOUNT= pmem (In reply to Nathan from comment #1) So should be: +BUILD_DEPENDS= autoconf:devel/autoconf (Meant to leave out) (In reply to Nathan from comment #1) Thanks for the feedback, I'll post an updated patch with your suggestions early next week. (In reply to D Scott Phillips from comment #3) You may also want to run portlint (https://www.freshports.org/ports-mgmt/portlint) to fix other minor issues. Created attachment 198783 [details]
v2-0001-New-port-devel-pmdk.patch
Changes since v1:
- change BUILD_DEPENDS=autoconf to USES=autoreconf:build
- simplify `strip` commands with a wildcard
- reorder variable definitions per the handbook
ping There are quite a lot of issues reported by portlint, btw. I've started looking into it and I created a revision on phabricator: https://reviews.freebsd.org/D18009 Feel free to commandeer that differential revision if you'd like to submit additional fixes. A commit references this bug: Author: 0mp Date: Fri Dec 7 13:41:28 UTC 2018 New revision: 486862 URL: https://svnweb.freebsd.org/changeset/ports/486862 Log: New port: devel/pmdk: Libraries and tools to manage and access persistent memory devices The Persistent Memory Development Kit (PMDK) is a collection of libraries and tools for System Administrators and Application Developers to simplify managing and accessing persistent memory devices. WWW: https://pmem.io/pmdk/ PR: 232690 Submitted by: D Scott Phillips <d.scott.phillips@intel.com> Reviewed by: mat, ndowens@yahoo.com (previous version) Approved by: mat (mentor) Differential Revision: https://reviews.freebsd.org/D18009 Changes: head/devel/Makefile head/devel/pmdk/ head/devel/pmdk/Makefile head/devel/pmdk/distinfo head/devel/pmdk/files/ head/devel/pmdk/files/patch-src_Makefile.inc head/devel/pmdk/files/patch-src_common.inc head/devel/pmdk/files/patch-src_common_os__auto__flush__linux.c head/devel/pmdk/files/patch-src_common_os__posix.c head/devel/pmdk/files/patch-src_common_queue.h head/devel/pmdk/pkg-descr head/devel/pmdk/pkg-message head/devel/pmdk/pkg-plist Committed! Thanks a lot! |
