Bug 232803

Summary: mail/dovecot: Startup script prints config on {re}start but shouldnt
Product: Ports & Packages Reporter: Oleg Strizhak <oleg>
Component: Individual Port(s)Assignee: Larry Rosenman <ler>
Status: Closed FIXED    
Severity: Affects Only Me Keywords: easy, needs-patch
Priority: --- Flags: ler: maintainer-feedback+
ler: merge-quarterly-
Version: Latest   
Hardware: Any   
OS: Any   

Description Oleg Strizhak 2018-10-30 07:17:40 UTC
it seems to me there's an error in files/dovecot.in @63rd line within the last modification. The correct string should be 

${command} ${command_args} -a 2>&1 >/dev/null

or

${command} ${command_args} -a >/dev/null

the actual string results in printing the whole config on every [re]start
Comment 1 Oleg Strizhak 2018-10-30 09:45:24 UTC
--- files/dovecot.in-bak	2018-10-30 02:28:26.000000000 +0300
+++ files/dovecot.in	2018-10-30 12:43:46.827723785 +0300
@@ -60,7 +60,7 @@
 	required_files="${config}"
 	command_args="-c ${config}"
 	if [ -s ${config} ]; then
-               ${command} ${command_args} -a 2>/dev/null
+               ${command} ${command_args} -a 2>&1 >/dev/null
                 if [ $? -ne 0 ]; then
                        echo "==Error=="
                        echo "Configuration file check failed."
Comment 2 commit-hook freebsd_committer 2018-10-30 14:04:59 UTC
A commit references this bug:

Author: ler
Date: Tue Oct 30 14:04:21 UTC 2018
New revision: 483490
URL: https://svnweb.freebsd.org/changeset/ports/483490

Log:
  mail/dovcecot: fix thinko in previous update.  Don't print config always

  PR:		232803
  Submitted by:	oleg@pcbtech.ru

Changes:
  head/mail/dovecot/Makefile
  head/mail/dovecot/files/dovecot.in
Comment 3 Larry Rosenman freebsd_committer 2018-10-30 14:06:04 UTC
Committed, thanks.

Sorry for the grief.