Bug 232803
| Summary: | mail/dovecot: Startup script prints config on {re}start but shouldnt | ||
|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Oleg Streejak <oleg> |
| Component: | Individual Port(s) | Assignee: | Larry Rosenman <ler> |
| Status: | Closed FIXED | ||
| Severity: | Affects Only Me | Keywords: | easy, needs-patch |
| Priority: | --- | Flags: | ler:
maintainer-feedback+
ler: merge-quarterly- |
| Version: | Latest | ||
| Hardware: | Any | ||
| OS: | Any | ||
--- files/dovecot.in-bak 2018-10-30 02:28:26.000000000 +0300
+++ files/dovecot.in 2018-10-30 12:43:46.827723785 +0300
@@ -60,7 +60,7 @@
required_files="${config}"
command_args="-c ${config}"
if [ -s ${config} ]; then
- ${command} ${command_args} -a 2>/dev/null
+ ${command} ${command_args} -a 2>&1 >/dev/null
if [ $? -ne 0 ]; then
echo "==Error=="
echo "Configuration file check failed."
A commit references this bug: Author: ler Date: Tue Oct 30 14:04:21 UTC 2018 New revision: 483490 URL: https://svnweb.freebsd.org/changeset/ports/483490 Log: mail/dovcecot: fix thinko in previous update. Don't print config always PR: 232803 Submitted by: oleg@pcbtech.ru Changes: head/mail/dovecot/Makefile head/mail/dovecot/files/dovecot.in Committed, thanks. Sorry for the grief. |
it seems to me there's an error in files/dovecot.in @63rd line within the last modification. The correct string should be ${command} ${command_args} -a 2>&1 >/dev/null or ${command} ${command_args} -a >/dev/null the actual string results in printing the whole config on every [re]start