Bug 232822
| Summary: | multimedia/mkvtoolnix: fix build with GCC-based architectures | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Piotr Kubaj <pkubaj> | ||||||
| Component: | Individual Port(s) | Assignee: | Thomas Zander <riggs> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | linimon, pkubaj | ||||||
| Priority: | --- | Keywords: | needs-qa, patch | ||||||
| Version: | Latest | Flags: | riggs:
maintainer-feedback+
|
||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Bug Depends on: | 232820, 232821 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
Thanks! Sadly, this breaks the build on 10.4, which is EOL'd, I know but please allow for some more investigation on my side before I commit this. Created attachment 198940 [details]
Set USE_CXXSTD only if clang is not used
Piotr, could you confirm that this works?
(In reply to Thomas Zander from comment #2) Ping I can confirm that this builds both on powerpc64 and amd64. A commit references this bug: Author: riggs Date: Sat Nov 24 12:00:57 UTC 2018 New revision: 485765 URL: https://svnweb.freebsd.org/changeset/ports/485765 Log: Fix build on GCC-based architectures PR: 232822 Submitted by: pkubaj@anongoth.pl Reviewed by: riggs, linimon Changes: head/multimedia/mkvtoolnix/Makefile |
Created attachment 198780 [details] patch We need to define USES=compiler:c++17-lang and USE_CXXSTD=c++17 to fix those errors when building with GCC: src/merge/mkvmerge.o:(.toc+0x10): undefined reference to `boost::system::detail::generic_category_instance' src/merge/mkvmerge.o:(.toc+0x18): undefined reference to `boost::system::detail::generic_category_instance' src/common/libmtxcommon.a(logger.o):(.toc+0x20): undefined reference to `boost::system::detail::system_category_instance' src/common/libmtxcommon.a(common.o):(.toc+0x18): undefined reference to `boost::system::detail::system_category_instance' Tested on powerpc64 and amd64. Hardware sponsored by IntegriCloud.