Bug 232876
| Summary: | science/voro++: Build shared library | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Yuri Victorovich <yuri> | ||||
| Component: | Individual Port(s) | Assignee: | Jason W. Bacon <jwb> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | jwb | ||||
| Priority: | --- | Flags: | tobik:
maintainer-feedback?
(jwb) |
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Inviting maintainer to the PR. Reviewing and testing... Committed with some changes, thanks! A commit references this bug: Author: jwb Date: Sun Nov 4 15:52:44 UTC 2018 New revision: 484101 URL: https://svnweb.freebsd.org/changeset/ports/484101 Log: science/voro++: Add shared library Consolidated build changes into patch files. Kept static lib as well as some dependencies may specify it explicitly (this is common in scientific software for better or worse) and the library is very small. PR: 232876 Reported by: yuri Approved by: jrm (mentor, implicit) Changes: head/science/voro++/Makefile head/science/voro++/files/ head/science/voro++/files/patch-Makefile head/science/voro++/files/patch-config.mk head/science/voro++/files/patch-src_Makefile head/science/voro++/pkg-descr head/science/voro++/pkg-plist |
Created attachment 198836 [details] patch Change static libary to shared library. Reason: It is easier to see if the dependent project is linked with a shared library vs. static library. Most library dependencies are through LIB_DEPENDS. For static library it is BUILD_DEPENDS. It is easier to keep all of them the same way. It is also better to not duplicate code, when every user has to include the full static library library. Also simplified the Makefile.