Bug 232951

Summary: www/nghttp2: Not broken with OpenSSL 1.1
Product: Ports & Packages Reporter: Bernard Spil <brnrd>
Component: Individual Port(s)Assignee: Po-Chuan Hsieh <sunpoet>
Status: Closed FIXED    
Severity: Affects Only Me Flags: bugzilla: maintainer-feedback? (sunpoet)
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
svn diff for www/nghttp2 none

Description Bernard Spil freebsd_committer freebsd_triage 2018-11-04 10:33:32 UTC 
Created attachment 198929 [details]
svn diff for www/nghttp2

Hi,

Currently the www/nghttp2 port is marked broken with security/openssl-devel. The security/openssl-devel port was just deleted.

From the BROKEN_SSL_REASON I saw that this it was broken with very early versions of the openssl-devel port but that was fixed.
Additionally, looking at the nghttp2 code, I see that NPN support is optional. See e.g. https://github.com/nghttp2/nghttp2/blob/master/src/nghttp.cc#L1101
> #ifndef OPENSSL_NO_NEXTPROTONEG
>     SSL_get0_next_proto_negotiated(ssl, &next_proto, &next_proto_len);
> #endif // !OPENSSL_NO_NEXTPROTONEG

The relevant commit in nghttp is https://github.com/nghttp2/nghttp2/commit/400934e5a31da0bb756534deefbdc3046e603258
which I created myself I just found out when I dug a bit deeper...

You're probably not getting pkg-fallout messages for 12 or head for the port either, another indication that it builds OK with OpenSSL 1.1

Cheers, Bernard.
Comment 1 commit-hook freebsd_committer freebsd_triage 2018-11-06 21:13:18 UTC 
A commit references this bug:

Author: sunpoet
Date: Tue Nov  6 21:12:32 UTC 2018
New revision: 484352
URL: https://svnweb.freebsd.org/changeset/ports/484352

Log:
  Remove outdated BROKEN_SSL

  PR:		232951
  Submitted by:	brnrd

Changes:
  head/www/nghttp2/Makefile
Comment 2 Po-Chuan Hsieh freebsd_committer freebsd_triage 2018-11-06 21:17:04 UTC 
Committed. Thanks!