Bug 232966
| Summary: | multimedia/emby-server: Bundle x264 | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Maxime Gauduin <alucryd> | ||||||||||||||||||
| Component: | Individual Port(s) | Assignee: | Li-Wen Hsu <lwhsu> | ||||||||||||||||||
| Status: | Closed FIXED | ||||||||||||||||||||
| Severity: | Affects Many People | CC: | alucryd, driesm, joshruehlig, lwhsu, ygy | ||||||||||||||||||
| Priority: | --- | Keywords: | needs-qa | ||||||||||||||||||
| Version: | Latest | Flags: | lwhsu:
maintainer-feedback+
|
||||||||||||||||||
| Hardware: | amd64 | ||||||||||||||||||||
| OS: | Any | ||||||||||||||||||||
| See Also: |
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=232935 https://reviews.freebsd.org/D19130 |
||||||||||||||||||||
| Bug Depends on: | |||||||||||||||||||||
| Bug Blocks: | 232935 | ||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||
|
Description
Maxime Gauduin
2018-11-04 19:03:04 UTC
Maintainer informed via mail Hey Maxime, Thanks for helping with this port. I have been the one updating (old PBI version of) FreeNAS plugin for emby. I have been attempting to update the PBI version of the plugin to 3.5.3.0 and in the process realized that the way things are now structured leads itself to dependency issues. Is it not possible to just include all necessary libraries for ffmpeg to execute? I think this is how plex is distributed, including it's own ffmpeg. Otherwise we will constantly be hitting issues where installed dependencies are not the exact version expected. I do not know if this suggestions would violate certain dependencies' licenses. In that case, maybe we could instead specify the exact library version needed. libopus.so.X:audio/opus But, this still isn't perfect because if opus was updated, we would need to update the emby-server port as well. Thanks, Josh Also, the current emby exe will not execute with just any mono. We should specify the minimum version in the port. I believe the below should work. mono>=5:lang/mono I agree, as long as we have shared library dependencies we will observe the same issues coming back. Ideally, the emby-server package bundles everything if licences permit. Waiting to hear back from Maxime where any further changes are going to be proposed with the diff before committing (as per conversation with Josh and Dries above). Hi Maxime, The other change I would recommend is that the MAINTAINER email address be set to the one you use here on Bugzilla, so any bug reports will notify you automatically. Should the port be changed so that MAINTAINER=alucryd@archlinux.org or will you open a bugzilla account with username apps@emby.media? Hi all, I have in fact another proposal, I will push this custom ffmpeg to Arch Linux in the future, and absolutely need to build it from source, so the source code will not just be available upon request but publicly available. I would like to build this custom ffmpeg in the FreeBSD port too, this way it will always be rebuilt against the binary system libraries and we won't face this issue anymore. I really don't want to duplicate the effort you've all spent building and patching the libraries we need by bundling all of them. @Ben Thanks for the feedback, I will change the maintainer email address to mine with the next update. I love where we are headed to fix it permanently in the future. I understand that this isn't an easy task to do in the short term. Maybe we can commit the patch as is to fix it temporarily? Also hit by this problem and would love to see a permanent fix. IANAPC (I am not a ports committer), but if I understand it correctly, if at least a temporary fix is not committed by the end of the year, it could also break latest, right? Yes it will. I will try to accelerate things on our end, I still need a public tarball of our ffmpeg to be produced, I will then proceed to upgrading the port with it. Our 3.6 release is just around the corner, I would like to get this done by then. Good news, I finally have a public ffmpeg tarball to play with. Quick question guys, if I were to build our custom ffmpeg inside the emby port, would I be able to build against libmp3lame even if it's not in the binary repositories? If not I'll need to bring libmp3lame along with it's headers and pkgconfig files which I really want to avoid. You can find libmp3lame in the audio/lame port. If you define a run_dependency against that it will get linked. [/usr/ports/audio/lame]$ cat pkg-plist | grep libmp3lame lib/libmp3lame.a lib/libmp3lame.so lib/libmp3lame.so.0 lib/libmp3lame.so.0.0.0 Created attachment 200124 [details]
Work in progress diff
Alright, I've been working on building ffmpeg directly. This is not the final diff, just to get some opinions. It still uses the 3.5.3.0 tarball which contained ffmpeg and its libs along with libx264 and libmp3lame. They will be gone with the next release which will happen soon. It will only contain the partially static ffmpeg built in the Makefile.
One worthy note, we will be reverting to using imagemagick until skia with dng support can be built on freebsd. I'm still pondering whether to use the system one (which is not built with ideal options) or ship our own.
Hi, I think the general approach is going the right way! I tried building the port in poudriere but it gave some errors. Also portlint -ac gives a few minor warnings. We use poudriere and portlint to check for QA. Could you check these out and update the diff accordingly.
This is the output of portlint -ac:
root@freebsd-head:/usr/ports/multimedia/emby-server # portlint -ac
WARN: /usr/ports/multimedia/emby-server/pkg-plist: [3]: installing shared libraries, please define USE_LDCONFIG as appropriate
WARN: Makefile: [94]: possible direct use of command "ln" found. use ${LN} instead.
WARN: Makefile: using hyphen in PORTNAME. consider using PKGNAMEPREFIX and/or PKGNAMESUFFIX.
WARN: /usr/ports/multimedia/emby-server/pkg-deinstall: possible use of absolute pathname "/var/db/emby-server".
Poudriere fails with this (don't know how to fix this, Ben could maybe give some feedback about this part):
=======================<phase: build >============================
===> Building for emby-server-3.5.3.0
(cd /wrkdirs/usr/ports/multimedia/emby-server/work/ffmpeg-2018_12_01 && ./configure --disable-bzlib --disable-doc --disable-ffplay --disable-shared --disable-vdpau --disable-libxcb --disable-libxcb-shm --disable-libxcb-xfixes --disable-libxcb-shape --disable-lzma --disable-sdl2 --disable-xlib --enable-fontconfig --enable-gmp --enable-gnutls
--enable-gpl --enable-libass --enable-libdrm --enable-libfreetype --enable-libfribidi --enable-libmp3lame --enable-libopus --enable-libsmbclient --enable-libtheora --enable-libvorbis --enable-libwebp --enable-libx264 --enable-libzvbi --enable-static --enable-vaapi --enable-version3 && gmake)
gcc is unable to create an executable file.
If gcc is a cross-compiler, use the --enable-cross-compile option.
Only do this if you know what cross compiling means.
C compiler test failed.
WARN: Makefile: using hyphen in PORTNAME. consider using PKGNAMEPREFIX and/or PKGNAMESUFFIX. This one should not be fixed I think ;) Created attachment 200228 [details]
WIP v2
Added USE_LDCONFIG and replaced ln with ${LN}. The absolute path in pkg-deinstall is just a comment, nothing to worry about.
I made some changes and tried poudriere, but it fails to build llvm60 here, and takes 4 hours to do so, so I gave up. Could you give the latest diff a try?
When is the new release coming out? We should try and push the bundled ffmpeg with the new version in the tree. I reached out to the multimedia mailing list to help us push this in the tree. Heads up - not much time left before breaking the new quarterly :) Created attachment 201338 [details]
4.0.1.0 diff
Hi folks, we finally got around publishing a new release, this latest diff should be the final one. Unfortunately I still can't test poudriere as it keeps failing to build llvm, so it would be awesome if someone else could. Portlint at least seems to be happy, and I can build and install the port fine locally.
On what version of FreeBSD are you testing this? Also what ports tree have you checked out? Head or quarterly? Thanks I'm testing on Freebsd11.2 latest cycle, with the head of the ports repository: uname -a FreeBSD freebsd11 11.2-RELEASE FreeBSD 11.2-RELEASE #0 r335510: Fri Jun 22 04:32:14 UTC 2018 root@releng2.nyi.freebsd.org:/usr/obj/usr/src/sys/GENERIC amd64 svn info /usr/portsPath: . Working Copy Root Path: /usr/ports URL: https://svn.freebsd.org/ports/head Relative URL: ^/head Repository Root: https://svn.freebsd.org/ports Repository UUID: 35697150-7ecd-e111-bb59-0022644237b5 Revision: 487425 Node Kind: directory Schedule: normal Last Changed Author: joneum Last Changed Rev: 487425 Last Changed Date: 2018-12-14 11:57:19 +0000 (Fri, 14 Dec 2018) Created attachment 201491 [details]
Using port variables not overwriting do-configure
Still some problems with shared libs, can't get samba to work error out with undefined symbols in its shared library. WIP
Created attachment 201800 [details]
upgrade emby-server to latest and greatest package
Attached patch uses port variables and adds 2 options (one for lame defaulting to off and one for samba defaulting to on). Lame defaults to off for licensing and samba defaults to on for full functionality of emby-server. Pkg-message adjusted to recommend compiling from ports with lame enabled for full functionality.
QA:
Portlint -ac
poudriere testport head
poudriere testport stable12
poudriere testport stable11
Ready to commit. Now only a developer is needed to commit it and give his approval on the suggested approach.
Created attachment 201822 [details]
update to latest and greatest
Forgot to add the sub files to the diff.
Created attachment 201850 [details]
update to latest and greatest
Add X11 option as this is also a much used option in /etc/make.conf
(In reply to Dries Michiels from comment #25) https://bugs.freebsd.org/bugzilla/attachment.cgi?id=201850&action=diff tested fine in my poudriere and ygy@ also verified it works. The only thing I want to check is, this patch removes "Created by" comment, is that ok'd by Ben? Hi, Please use the diff from the review, mat went over some of the things. Much improved version :-). https://reviews.freebsd.org/D19130 As for the consent of Ben, he gave this in the following PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231669 Although, I don't actually mind that the line stay as well as the maintainer. Hi guys, I'd like to give a friendly bump on this PR. Li-Wen Hsu, would you mind committing the patch that is in the phabricator review? I don't think there will be any more comments on the diff. Thanks! If mat@ has no further comment on the review I think this can be committed. And share the love of an updated emby-server with everyone ;). Thanks guys! (In reply to Dries Michiels from comment #29) I also think it's fine to get in the tree. After reading the comments in this one and https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=232935 , the patch in https://reviews.freebsd.org/D19130 fixes both issues, do I understand correctly? Also, Maxime, could you do the final maintainer approval for the patch in https://reviews.freebsd.org/D19130 ? (In reply to Li-Wen Hsu from comment #30) Registered and approved the diff over there, hopefully I got it right, this was a first for me. (In reply to Li-Wen Hsu from comment #30) Exactly! This update fixes that issue as we are now building the ffmpeg locally and always link against the (updated) correct shared library version. Dries, thanks for the explanation. I'm working on it right now. Maxime, thanks for the approval, in fact I was asking an approval here, which is enough. It's even better you open a phabricator account, I'm looking forward to seeing more patches from you. :-) A commit references this bug: Author: lwhsu Date: Mon Mar 4 20:14:40 UTC 2019 New revision: 494643 URL: https://svnweb.freebsd.org/changeset/ports/494643 Log: - Update to 4.0.2.0 [1] - Fix cannot fix shared library errors [2] [3] - Update maintainer's email [3] PR: 232935 [2] 232966 [3] Submitted by: Dries Michiels <driesm.michiels@gmail.com> [1] [2] Maxime Gauduin <alucryd@archlinux.org> [3] Approved by: Maxime Gauduin <alucryd@archlinux.org> (maintainer) Differential Revision: https://reviews.freebsd.org/D19130 Changes: head/multimedia/emby-server/Makefile head/multimedia/emby-server/distinfo head/multimedia/emby-server/files/ImageMagickSharp.dll.config.in head/multimedia/emby-server/files/SQLitePCLRaw.provider.sqlite3.dll.config.in head/multimedia/emby-server/files/emby-server.in head/multimedia/emby-server/pkg-message head/multimedia/emby-server/pkg-plist Thank you for committing this! (In reply to Li-Wen Hsu from comment #33) Thank you Li-Wen!! |
