Bug 232967
| Summary: | multimedia/vlc3: Fails to install (stage) with NLS unset. Prevents share/vlc.appdata.xml from being created | ||
|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Trond Endrestøl <Trond.Endrestol> |
| Component: | Individual Port(s) | Assignee: | Thomas Zander <riggs> |
| Status: | Closed FIXED | ||
| Severity: | Affects Some People | CC: | Trond.Endrestol, riggs |
| Priority: | --- | Keywords: | needs-patch |
| Version: | Latest | Flags: | riggs:
maintainer-feedback+
riggs: merge-quarterly+ |
| Hardware: | Any | ||
| OS: | Any | ||
A commit references this bug: Author: riggs Date: Sat Nov 10 12:46:46 UTC 2018 New revision: 484606 URL: https://svnweb.freebsd.org/changeset/ports/484606 Log: Fix build with NLS disabled Details: - Unconditionally depend on gettext-tools at build time since msgfmt is still required to create vlc.appdata.xml PR: 232967 Reported by: Trond.Endrestol@ximalas.info MFH: 2018Q4 Changes: head/multimedia/vlc3/Makefile A commit references this bug: Author: riggs Date: Sat Nov 10 13:11:13 UTC 2018 New revision: 484609 URL: https://svnweb.freebsd.org/changeset/ports/484609 Log: MFH: r484606 Fix build with NLS disabled Details: - Unconditionally depend on gettext-tools at build time since msgfmt is still required to create vlc.appdata.xml PR: 232967 Reported by: Trond.Endrestol@ximalas.info Approved by: ports-secteam (riggs) Changes: _U branches/2018Q4/ branches/2018Q4/multimedia/vlc3/Makefile |
If I unset NLS, this happens during configure: checking whether NLS is requested... no checking for msgfmt... no checking for gmsgfmt... : checking for xgettext... no checking for msgmerge... no and this happens during stage: Making install in share gmake[4]: Entering directory '/construction/xports/multimedia/vlc3/work/vlc-3.0.4/share' : --xml --template vlc.appdata.xml.in -d ../po -o vlc.appdata.xml || cp vlc.appdata.xml.in vlc.appdata.xml gmake[5]: Entering directory '/construction/xports/multimedia/vlc3/work/vlc-3.0.4/share' gmake[5]: Nothing to be done for 'install-exec-am'. : --xml --template vlc.appdata.xml.in -d ../po -o vlc.appdata.xml || cp vlc.appdata.xml.in vlc.appdata.xml /bin/mkdir -p '/construction/xports/multimedia/vlc3/work/stage/usr/local/share/metainfo' install -m 0644 ./vlc.appdata.xml '/construction/xports/multimedia/vlc3/work/stage/usr/local/share/metainfo' install: ./vlc.appdata.xml: No such file or directory Judging by the executed commands, it would be better if gmsgfmt is set to false, failing the first part of the two commands above, falling back to simply copying the input file to the output file. Patching ${WRKSRC}/share/Makefile is also a possibility. Complete build logs are available at https://ximalas.info/~trond/vlc3/ due to the size restrictions of bz.