Bug 233046

Summary: [PATCH] tools/build/mk/OptionalObsoleteFiles.inc: clean rc.d and periodic files
Product: Base System Reporter: Ivan Rozhuk <rozhuk.im>
Component: confAssignee: Andriy Voskoboinyk <avos>
Status: Closed FIXED    
Severity: Affects Many People CC: 0mp, avos, dmitry.wagin, markj, philippe.michel7, rozhuk.im
Priority: --- Flags: 0mp: mfc-stable12?
0mp: mfc-stable11?
Version: 11.2-STABLE   
Hardware: Any   
OS: Any   
Bug Depends on:    
Bug Blocks: 227984, 232978    
Attachments:
Description Flags
patch
none
up: add more files and dirs
none
add ssh dir none

Description Ivan Rozhuk 2018-11-06 23:58:57 UTC
Created attachment 199032 [details]
patch

After set some WITHOUT_ options in /etc/src.conf some csripts not deleted, but files that should rum from this scripts is deleted.
Clean unneded files.
Comment 1 Ivan Rozhuk 2018-11-08 01:42:07 UTC
Created attachment 199070 [details]
up: add more files and dirs
Comment 2 Ivan Rozhuk 2018-11-08 02:26:13 UTC
Created attachment 199072 [details]
add ssh dir
Comment 3 Andriy Voskoboinyk freebsd_committer freebsd_triage 2019-02-16 05:00:55 UTC
> OLD_FILES+=etc/gss/mech
> +OLD_FILES+=etc/gss/qop
> +OLD_DIRS+=etc/gss
> +OLD_FILES+=etc/rc.d/gssd

> +OLD_FILES+=etc/rc.d/route6d
> +OLD_FILES+=etc/rc.d/rtadvd
> +OLD_FILES+=etc/rc.d/rtsold

> OLD_FILES+=etc/rc.d/ipfilter
> +OLD_FILES+=etc/rc.d/ipfs
> +OLD_FILES+=etc/rc.d/ipmon
> +OLD_FILES+=etc/rc.d/ipnat

> +OLD_FILES+=etc/rc.d/natd

> +OLD_FILES+=etc/rc.d/pppoed

> +OLD_FILES+=etc/rc.d/ntpdate

> +OLD_FILES+=etc/rc.d/pf
> +OLD_FILES+=etc/rc.d/pflog
> +OLD_FILES+=etc/rc.d/pfsync

> +OLD_FILES+=etc/rc.d/ppp

> +OLD_FILES+=etc/rc.d/quota

These are installed unconditionally; additional changes to the corresponding Makefile's required. For now, these were omitted from commit; there are enough other changes.


> +OLD_FILES+=etc/rc.d/ipfw_netflow

This one depends on netgraph && ipfw (included)


> +OLD_DIRS+=etc/mail

Depends on mailwrapper too; not included since there are some other files left
(from sendmail?)

> +OLD_DIRS+=etc/zfs
With /etc/zfs/exports included (created by /etc/rc.d/zfs)
Comment 4 commit-hook freebsd_committer freebsd_triage 2019-02-16 05:04:15 UTC
A commit references this bug:

Author: avos
Date: Sat Feb 16 05:04:02 UTC 2019
New revision: 344208
URL: https://svnweb.freebsd.org/changeset/base/344208

Log:
  Add more rc.d scripts / empty directors / config files into
  OptionalObsoleteFiles.inc

  Note: only files with conditional installation logic were
  included from the PR.

  PR:		233046
  Submitted by:	<rozhuk.im@gmail.com>
  MFC after:	5 days

Changes:
  head/tools/build/mk/OptionalObsoleteFiles.inc
Comment 5 Ed Maste freebsd_committer freebsd_triage 2019-04-01 13:26:22 UTC
*** Bug 236761 has been marked as a duplicate of this bug. ***
Comment 6 Mark Johnston freebsd_committer freebsd_triage 2020-06-07 18:08:44 UTC
(In reply to commit-hook from comment #4)
Was there any reason this wasn't merged to stable/12?
Comment 7 Mark Johnston freebsd_committer freebsd_triage 2020-06-07 18:09:27 UTC
*** Bug 244378 has been marked as a duplicate of this bug. ***
Comment 8 Mateusz Piotrowski freebsd_committer freebsd_triage 2021-02-08 13:43:09 UTC
Can we close this PR or do we still want to MFC?
Comment 9 Mateusz Piotrowski freebsd_committer freebsd_triage 2021-02-08 13:43:46 UTC
Sign to the developer who committed the patch.
Comment 10 Mark Linimon freebsd_committer freebsd_triage 2023-12-25 14:47:16 UTC
^Triage: committed back in 2021.  The mfc-stable* flags' values are now OBE.