Bug 233066

Summary: lang/duktape-lib: respect CC
Product: Ports & Packages Reporter: Koichiro Iwao <meta>
Component: Individual Port(s)Assignee: Koichiro Iwao <meta>
Status: Closed FIXED    
Severity: Affects Only Me CC: asiciliano, meta
Priority: --- Flags: asiciliano: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch meta: maintainer-approval? (asiciliano)

Description Koichiro Iwao freebsd_committer freebsd_triage 2018-11-08 08:50:45 UTC 
Created attachment 199075 [details]
patch

I noticed patch-Makefile.sharedlibrary is not necessary.
Setting CC=cc is bad for people who want to gcc.
${CC} will be a c compiler that user choose.

https://www.freebsd.org/doc/en/books/porters-handbook/dads-cc.html
Comment 1 Alfonso S. Siciliano freebsd_committer freebsd_triage 2018-11-12 13:24:00 UTC 
Thank you for your suggestion,

I have update the port with the patch bug #233159

Regards
Afonso
Comment 2 Alfonso S. Siciliano freebsd_committer freebsd_triage 2018-11-12 13:25:58 UTC 
You could close the bug,
thanks,
Alfonso
Comment 3 Koichiro Iwao freebsd_committer freebsd_triage 2018-11-12 14:51:35 UTC 
*** Bug 233159 has been marked as a duplicate of this bug. ***
Comment 4 Koichiro Iwao freebsd_committer freebsd_triage 2018-11-12 14:52:17 UTC 
Just approve it.
Comment 5 commit-hook freebsd_committer freebsd_triage 2018-11-12 14:55:11 UTC 
A commit references this bug:

Author: meta
Date: Mon Nov 12 14:54:45 UTC 2018
New revision: 484805
URL: https://svnweb.freebsd.org/changeset/ports/484805

Log:
  lang/duktape-lib: respect CC

  PR:		233066
  Submitted by:	myself
  Approved by:	maintainer, mentors (implicit)

Changes:
  head/lang/duktape-lib/Makefile
  head/lang/duktape-lib/files/