Bug 233090

Summary:	dns/dnscrypt-proxy2: relies on deprecated sys/capability.h header for Capsicum
Product:	Ports & Packages	Reporter:	Ed Maste <emaste>
Component:	Individual Port(s)	Assignee:	Walter Schwarzenfeld <w.schwarzenfeld>
Status:	Closed Overcome By Events
Severity:	Affects Only Me	CC:	w.schwarzenfeld
Priority:	---
Version:	Latest
Hardware:	Any
OS:	Any
Bug Depends on:	233092
Bug Blocks:	228878

Description Ed Maste freebsd_committer

2018-11-09 18:11:56 UTC

sys/capability.h will be removed before FreeBSD 13. The (now) correct header to use on all supported (and most unsupported) versions of FreeBSD is sys/capsicum.h.

There's no need for autoconf checks etc. to check for both (in the ports tree) but upstream may want to if there's a desire to build on older releases.

work/dnscrypt-proxy-2.0.17/vendor/golang.org/x/sys/unix/types_freebsd.go
25:#include <sys/capability.h>

Comment 1 Bugzilla Automation freebsd_committer

2018-11-09 18:11:56 UTC

Maintainer informed via mail

Comment 2 Ed Maste freebsd_committer

2018-11-12 16:20:12 UTC

It appears this is simply a side-effect of go's use of capability.h - see PR 233092.

Comment 3 Walter Schwarzenfeld 2019-02-11 11:53:37 UTC

grep of the source-code for "capsicum.h" shows

usr/ports/dns/dnscrypt-proxy2/work/dnscrypt-proxy-2.0.19/vendor/golang.org/x/sys/unix/mkerrors.sh:#include <sys/capsicum.h>
/usr/ports/dns/dnscrypt-proxy2/work/dnscrypt-proxy-2.0.19/vendor/golang.org/x/sys/unix/types_freebsd.go:#include <sys/capsicum.h>

And no output for "capability.h".

So I close here, with overcome by events.