Bug 233091

Summary: devel/gitlab-shell: relies on deprecated sys/capability.h header for Capsicum
Product: Ports & Packages Reporter: Ed Maste <emaste>
Component: Individual Port(s)Assignee: Matthias Fechner <mfechner>
Status: Closed FIXED    
Severity: Affects Only Me CC: w.schwarzenfeld
Priority: --- Flags: bugzilla: maintainer-feedback? (mfechner)
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on: 233092    
Bug Blocks: 228878    

Description Ed Maste freebsd_committer freebsd_triage 2018-11-09 18:16:57 UTC 
sys/capability.h will be removed before FreeBSD 13. The (now) correct header to use on all supported (and most unsupported) versions of FreeBSD is sys/capsicum.h.

There's no need for autoconf checks etc. to check for both (in the ports tree) but upstream may want to if there's a desire to build on older releases.

go/vendor/golang.org/x/sys/unix/mkerrors.sh
82:#include <sys/capability.h>
Comment 1 Ed Maste freebsd_committer freebsd_triage 2018-11-12 16:18:22 UTC 
It appears this is simply a side-effect of go's use of capability.h - see PR 233092.
Comment 2 Matthias Fechner freebsd_committer freebsd_triage 2018-11-24 21:58:56 UTC 
(In reply to Ed Maste from comment #1)
so if this is a GO problem, can we close this issue?
Or is there any need for gitlab-shell?
Comment 3 Ed Maste freebsd_committer freebsd_triage 2018-11-25 00:21:06 UTC 
(In reply to Matthias Fechner from comment #2)
We'll probably still need to patch devel/gitlab-shell until the change makes its way into a new release.
Comment 4 Walter Schwarzenfeld 2019-02-12 03:56:42 UTC 
A grep through the source shows it is changed to capsicum.h, I think we can close here.
Comment 5 Ed Maste freebsd_committer freebsd_triage 2019-06-18 14:18:37 UTC 
Close per comment #4