Bug 233103
| Summary: | textproc/fcitx-table-other: fix build | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Henry Hu <henry.hu.sh> | ||||
| Component: | Individual Port(s) | Assignee: | Steve Wills <swills> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | ||||||
| Priority: | --- | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Comment on attachment 199104 [details]
patch to fix build
Since this is to fix a build, port will need a PORTREVISION bump
(In reply to Nathan from comment #1) According to the porters handbook: https://www.freebsd.org/doc/en/books/porters-handbook/makefile-naming.html Examples of changes which do not require a PORTREVISION bump: Build fixes which cause a package to become compilable where it was previously failing. As long as the changes do not introduce any functional change on any other platforms on which the port did previously build. Since PORTREVISION reflects the content of the package, if the package was not previously buildable then there is no need to increase PORTREVISION to mark a change. So no PORTREVISION bump is needed here. A commit references this bug: Author: swills Date: Sat Nov 10 13:16:06 UTC 2018 New revision: 484610 URL: https://svnweb.freebsd.org/changeset/ports/484610 Log: textproc/fcitx-table-other: fix build PR: 233103 Submitted by: Henry Hu <henry.hu.sh@gmail.com> (maintainer) Changes: head/textproc/fcitx-table-other/Makefile Committed, thanks! |
Created attachment 199104 [details] patch to fix build Recently, fcitx-table-other cannot be built. The reason seems to be that its build process actually depends on bash, which is missing from its BUILD_DEPENDS. Previously, maybe some of its dependencies depend on bash, but now this dependency must be explicitly specified.