Bug 233201

Summary: net-p2p/namecoin: Update to 0.17.0
Product: Ports & Packages Reporter: Chad Jacob Milios <milios>
Component: Individual Port(s)Assignee: Koichiro Iwao <meta>
Status: Closed FIXED    
Severity: Affects Some People CC: hrs, meta, milios, pi
Priority: --- Keywords: needs-patch, needs-qa
Version: LatestFlags: milios: maintainer-feedback+
Hardware: Any   
OS: Any   
Attachments:
Description Flags
svn diff from /usr/ports
milios: maintainer-approval+
namecoin-qt5
meta: maintainer-approval+
svn diff from /usr/ports milios: maintainer-approval+

Description Chad Jacob Milios 2018-11-13 15:15:58 UTC 
Created attachment 199209 [details]
svn diff from /usr/ports

tested on 11.2/amd64
Comment 1 Koichiro Iwao freebsd_committer freebsd_triage 2018-11-17 15:15:22 UTC 
Take.
Comment 2 Tobias Kortkamp freebsd_committer freebsd_triage 2018-11-17 15:24:31 UTC 
Comment on attachment 199209 [details]
svn diff from /usr/ports

+	${INSTALL} ${FILESDIR}/namecoin-qt.desktop \
+		${STAGEDIR}${PREFIX}/share/applications/

This should use ${INSTALL_DATA} so that it gets the right permissions.
Comment 3 Koichiro Iwao freebsd_committer freebsd_triage 2018-11-18 04:33:38 UTC 
testbuild@12amd64 fails due to dependent port fails.
net/qt4-network is required but it doesn't build with OpenSSL 1.1.x.
Comment 4 Koichiro Iwao freebsd_committer freebsd_triage 2018-11-19 09:20:10 UTC 
Created attachment 199334 [details]
namecoin-qt5

Switched to QT5. What about this?
Comment 5 Chad Jacob Milios 2018-11-20 12:24:39 UTC 
Comment on attachment 199334 [details]
namecoin-qt5

the COMMENT?= was because COMMENT is already set differently by the slave ports. beside that this is perfect. thanks
Comment 6 Koichiro Iwao freebsd_committer freebsd_triage 2018-11-20 13:31:07 UTC 
(In reply to Chad Jacob Milios from comment #5)
Okay, sorry about that. I'll chaenge it back.
Comment 7 Chad Jacob Milios 2018-11-25 19:00:23 UTC 
Created attachment 199553 [details]
svn diff from /usr/ports

incorporates switch from QT4 to QT5
Comment 8 commit-hook freebsd_committer freebsd_triage 2018-11-26 02:05:33 UTC 
A commit references this bug:

Author: meta
Date: Mon Nov 26 02:04:58 UTC 2018
New revision: 485911
URL: https://svnweb.freebsd.org/changeset/ports/485911

Log:
  net-p2p/namecoin: Update to 0.17.0

  Also, switched to Qt5 because net/qt4-network is required by dependency
  however it fails to build with OpenSSL 1.1.1. FreeBSD base OpenSSL has been
  switched to 1.1.1 since FreeBSD 12.

  PR:		233201
  Submitted by:	Chad Jacob Milios <milios@ccsys.com> (maintainer)
  Approved by:	mentors (implicit)

Changes:
  head/net-p2p/namecoin/Makefile
  head/net-p2p/namecoin/distinfo
  head/net-p2p/namecoin/files/namecoin-qt.desktop
Comment 9 Koichiro Iwao freebsd_committer freebsd_triage 2018-11-26 02:22:51 UTC 
Committed, thanks! Sorry for making you wait.