Bug 233284

Summary:	ZFS FAQ page mentions wrong TRIM sysctl
Product:	Documentation	Reporter:	Rebecca Cran <bcran>
Component:	Books & Articles	Assignee:	freebsd-doc (Nobody) <doc>
Status:	Closed FIXED
Severity:	Affects Some People	CC:	bcr
Priority:	---
Version:	Latest
Hardware:	Any
OS:	Any

Description Rebecca Cran freebsd_committer

2018-11-18 01:53:48 UTC

The FAQ page for ZFS (https://www.freebsd.org/doc/en/books/faq/all-about-zfs.html#idp59540680) says:

ZFS TRIM is enabled by default, and can be turned off by adding this line to /etc/sysctl.conf:

vfs.zfs.trim_disable=1

However, it looks like it was renamed in 2013 from trim_disable to trim.enabled:


commit 61d529d085e6782aaaceec7e1beed1de853df302
Author: smh <smh@FreeBSD.org>
Date:   Fri Apr 26 11:24:20 2013 +0000

    Changed ZFS TRIM sysctl from vfs.zfs.trim_disable -> vfs.zfs.trim.enabled
    Enabled ZFS TRIM by default
    
    Reviewed by:    pjd (mentor)
    Approved by:    pjd (mentor)
    MFC after:      2 weeks

Comment 1 commit-hook freebsd_committer

2018-11-18 11:10:01 UTC

A commit references this bug:

Author: bcr
Date: Sun Nov 18 11:08:59 UTC 2018
New revision: 52497
URL: https://svnweb.freebsd.org/changeset/doc/52497

Log:
  The sysctl vfs.zfs.trim_disable was renamed in 2013
  to vfs.zfs.trim.enabled and was enabled by default.
  Change the example on how to disable trim support
  to the new sysctl and assign 0 to it to disable it.

  PR:		    233284
  Submitted by:	    bcran@

Changes:
  head/en_US.ISO8859-1/books/faq/book.xml

Comment 2 Benedict Reuschling freebsd_committer

2018-11-18 11:11:15 UTC

Good catch, thanks for the report. I just fixed it.