Bug 233314

Summary:	"<repo> r<revision>" not auto-linked when at the beginning of line, if not on the first line, of comment
Product:	Services	Reporter:	Kubilay Kocak <koobs>
Component:	Bug Tracker	Assignee:	Oleksandr Tymoshenko <gonzo>
Status:	Closed FIXED
Severity:	Affects Only Me	CC:	bugmeister, gonzo
Priority:	---	Keywords:	needs-qa
Version:	unspecified
Hardware:	Any
OS:	Any
See Also:	https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=208938 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=233173

Description Kubilay Kocak freebsd_committer

2018-11-19 07:32:02 UTC

bug 208938 comment 5 contains two strings referring to base commit revisions, which were expected to be auto-linked after submission, but were not.

See Also, bug 171246, which contains a commit log message containing the same strings (format "base rXXXXX") which are auto-linked correctly

I'll recreate the strings below with a few variations, in anticipation of figuring out what the string match isn't picking up.

Original strings:

base r335642 (current: 12.0)
base r335863 (mfc: stable/11)

Original strings minus () suffixes:

base r335642
base r335863

Original strings not at the beginning of the line:

commit base r335642
commit base r335863

Comment 1 Kubilay Kocak freebsd_committer

2018-11-19 07:33:55 UTC

Looks like the strings aren't matched when they are at the beginning of the line.

Might want to check the ports (and other?) autolink matching entries for the same issue

Comment 2 Kubilay Kocak freebsd_committer

2018-11-19 07:35:21 UTC

Testing ports revision matching at beginning of the line:

ports r444534

commit ports r444534

Comment 3 Kubilay Kocak freebsd_committer

2018-11-21 03:59:42 UTC

bug 233173 comment 5 has a "ports r<revision>" string at the beginning of the line, on the first line, which was auto-linked. 

I will test this case here in 3 subsequent comments for base, doc and ports

Comment 4 Kubilay Kocak freebsd_committer

2018-11-21 04:00:16 UTC

ports r485451

Comment 5 Kubilay Kocak freebsd_committer

2018-11-21 04:00:31 UTC

base r335642

Comment 6 Kubilay Kocak freebsd_committer

2018-11-21 04:02:45 UTC

doc r52490

Comment 7 Kubilay Kocak freebsd_committer

2018-11-21 04:03:51 UTC

Confirming doc revision matching at beginning of the line is also affected

doc r52490

commit doc r52490

Comment 8 Oleksandr Tymoshenko freebsd_committer

2019-01-12 21:45:56 UTC

The problem was a missing flag in perl regex for multi-line text. Fix committed [1] and deployed.

[1] https://github.com/gonzoua/bugzilla/commit/5a3933a045e346abc74171bfd119e00f791d3d76

Comment 9 Kubilay Kocak freebsd_committer

2019-01-13 02:41:18 UTC

Thank you!