Bug 233319

Summary: net-mgmt/unbound_exporter: Update to upstream b7e842d8
Product: Ports & Packages Reporter: Athanasios Douitsis <aduitsis>
Component: Individual Port(s)Assignee: Kubilay Kocak <koobs>
Status: Closed FIXED    
Severity: Affects Some People CC: aduitsis, aduitsis, dmgk, gert
Priority: --- Keywords: needs-qa
Version: LatestFlags: aduitsis: maintainer-feedback+
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Update from 0.1 to 0.1_1
koobs: maintainer-approval+
unbound_exporter-0.1.20.patch dmgk: maintainer-approval?

Description Athanasios Douitsis 2018-11-19 13:42:52 UTC 
Updating this port to b7e842d893d29 of its master. A new metric (query_tls_total) is added which is considered very useful.

The updated port is at https://github.com/aduitsis/unbound_exporter_freebsd_port. Can provide patch if needed.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2018-11-20 11:50:16 UTC 
 Athanasios, a diff against the current port would be great
Comment 2 Athanasios Douitsis 2018-11-21 13:31:14 UTC 
Created attachment 199414 [details]
Update from 0.1 to 0.1_1
Comment 3 Gert Doering 2018-12-14 10:21:11 UTC 
Hi, any particular reason that's holding this up?  We'd like to roll this out and abandon our self-compiled unbound-exporter binaries...  thanks
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2018-12-14 10:31:38 UTC 
Comment on attachment 199414 [details]
Update from 0.1 to 0.1_1

Reporter is MAINTAINER, approve accordingly:

Approved by: Athanasios Douitsis <aduitsis cpan org>
Comment 5 Athanasios Douitsis 2018-12-14 16:39:52 UTC 
Beg pardon, do I need to approve anything? If so, how exactly do I go about it?
Comment 6 Kubilay Kocak freebsd_committer freebsd_triage 2018-12-16 13:29:27 UTC 
(In reply to Athanasios Douitsis from comment #5)

I've already set that for you (see comment 4)

To do it yourself in future issues:

  Attachment -> Details -> maintainer-approval [+]
Comment 7 Athanasios Douitsis 2018-12-17 09:37:13 UTC 
(In reply to Kubilay Kocak from comment #6)

Okay! Many many thanks!
Comment 8 Gert Doering 2019-01-21 12:24:13 UTC 
Sorry to be an annoyance again - what is needed to move this forward?  It looks a bit like everyone is waiting for someone else... who needs to do something now?

Anything I can do to help?
Comment 9 Gert Doering 2019-04-17 08:29:36 UTC 
sorry for being annoying... anything I can do to help get this un-stuck?
Comment 10 Athanasios Douitsis 2019-04-17 08:31:28 UTC 
What Gert said. Port maintainer here, is there any way we can assist?
Comment 11 Kubilay Kocak freebsd_committer freebsd_triage 2019-04-20 14:35:03 UTC 
Aside from confirmation of QA (portlint / poudriere), it's likely to be just waiting for someone with Go/golang experience to review/test before committing.

FWIW, the patch as supplied doesn't apply as is. Having said that, ive made the changes to the port manually, and will run through QA. If it passes I'll commit it as is.

For example, as is, the port fails portlint with:

===> Validating port with portlint
WARN: Makefile: [39]: possible direct use of command "echo" found. use ${ECHO_CMD} or ${ECHO_MSG} instead.
FATAL: Makefile: DISTVERSIONPREFIX appears out-of-order.
FATAL: Makefile: order must be PORTNAME/PORTVERSION/DISTVERSIONPREFIX/DISTVERSION/DISTVERSIONSUFFIX/PORTREVISION/PORTEPOCH/CATEGORIES/MASTER_SITES/MASTER_SITE_SUBDIR/PROJECTHOST/PKGNAMEPREFIX/PKGNAMESUFFIX/DISTNAME/EXTRACT_SUFX/DISTFILES/DIST_SUBDIR/EXTRACT_ONLY.
2 fatal errors and 1 warning found.

For future issues, it's really important as a maintainer to run a port through as much QA as possible, at the very least portlint and poudriere, and confirm that the port passes QA when submitting the changes. Doing so picks up many issues before submission that can prevent an issue from progressing quickly.

Also, regarding the PORTVERSION, it would be great to see upstream start to use Git tags to tag proper version numbers (x.y.z), so that this port can use those tags, instead of git tags directly to fetch the code, and reference in PORTVERSION
Comment 12 Dmitri Goutnik freebsd_committer freebsd_triage 2019-04-20 15:17:43 UTC 
Created attachment 203831 [details]
unbound_exporter-0.1.20.patch

I've rewrote patch a bit to

- use DISTVERSIONSUFFIX instead of GH_TAGNAME, as recommended by PHB
- set GH_SUBDIR in GH_TUPLE entries instead of manually creating them in pre-build
- remove do-install target, go.mk already does that
- add missing github.com/Sirupsen/logrus and golang.org/x/sys deps

Builds fine in poudriere on 112a, 120a and 120i, portlint is ok. Please review and approve.
Comment 13 commit-hook freebsd_committer freebsd_triage 2019-04-20 15:20:02 UTC 
A commit references this bug:

Author: koobs
Date: Sat Apr 20 15:19:51 UTC 2019
New revision: 499446
URL: https://svnweb.freebsd.org/changeset/ports/499446

Log:
  net-mgmt/unbound_exporter: Update to upstream b7e842d8

  While I'm here:

    - Pet portlint: DISTVERSIONPREFIX order, Group USES/GH-*, echo

  PR:		233319
  Submitted by:	Athanasios Douitsis <aduitsis cpan org> (maintainer)

Changes:
  head/net-mgmt/unbound_exporter/Makefile
  head/net-mgmt/unbound_exporter/distinfo
Comment 14 Kubilay Kocak freebsd_committer freebsd_triage 2019-04-20 15:23:20 UTC 
(In reply to Dmitri Goutnik from comment #12)

Thanks Dmitri. Please open a new/separate issue, with the patch updated/rebased against the latest revision (after ports r499446) of the port, that way it can be taken care of independently.
Comment 15 Athanasios Douitsis 2019-04-28 15:31:10 UTC 
Comment on attachment 203831 [details]
unbound_exporter-0.1.20.patch

Many thanks! I approved here, but I see that a separate ticket was requested. If I need to approve it, please let me know.