Bug 233500
| Summary: | audio/fluidplug-lv2: fails to build with fluidsynth 2.x | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Jan Beich <jbeich> | ||||
| Component: | Individual Port(s) | Assignee: | Yuri Victorovich <yuri> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | tobik, yuri | ||||
| Priority: | --- | Keywords: | needs-patch | ||||
| Version: | Latest | Flags: | bugzilla:
maintainer-feedback?
(yuri) |
||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| URL: | https://github.com/falkTX/FluidPlug/issues/6 | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 233448 | ||||||
| Attachments: |
|
||||||
Created attachment 199952 [details]
fluidplug-lv2-fluidsynth2.diff
Hi Yuri,
this patch fixes the build with FluidSynth 2.x. Can you check if it works
at runtime too?
If this works for you, I'll open a PR for this upstream.
Thanks.
(In reply to Tobias Kortkamp from comment #1) Pull Request: https://github.com/falkTX/FluidPlug/pull/7 Committed as PATCHxx statements. A commit references this bug: Author: yuri Date: Sat Dec 8 17:16:23 UTC 2018 New revision: 486965 URL: https://svnweb.freebsd.org/changeset/ports/486965 Log: audio/fluidplug-lv2: Fix build with fluidsynth 2.x Add PATCHxx statements for https://github.com/falkTX/FluidPlug/pull/7. PR: 233500 Submitted by: tobik Reported by: jbeich Changes: head/audio/fluidplug-lv2/Makefile head/audio/fluidplug-lv2/distinfo |
source/FluidPlug.c:133:20: error: variable has incomplete type 'fluid_preset_t' (aka 'struct _fluid_preset_t') fluid_preset_t preset; ^ /usr/local/include/fluidsynth/types.h:41:16: note: forward declaration of 'struct _fluid_preset_t' typedef struct _fluid_preset_t fluid_preset_t; /**< SoundFont preset */ ^ source/FluidPlug.c:135:10: error: incomplete definition of type 'struct _fluid_sfont_t' sfont->iteration_start(sfont); ~~~~~^ /usr/local/include/fluidsynth/types.h:40:16: note: forward declaration of 'struct _fluid_sfont_t' typedef struct _fluid_sfont_t fluid_sfont_t; /**< SoundFont */ ^ source/FluidPlug.c:136:26: error: incomplete definition of type 'struct _fluid_sfont_t' for (count = 0; sfont->iteration_next(sfont, &preset) != 0;) ~~~~~^ /usr/local/include/fluidsynth/types.h:40:16: note: forward declaration of 'struct _fluid_sfont_t' typedef struct _fluid_sfont_t fluid_sfont_t; /**< SoundFont */ ^ source/FluidPlug.c:147:10: error: incomplete definition of type 'struct _fluid_sfont_t' sfont->iteration_start(sfont); ~~~~~^ /usr/local/include/fluidsynth/types.h:40:16: note: forward declaration of 'struct _fluid_sfont_t' typedef struct _fluid_sfont_t fluid_sfont_t; /**< SoundFont */ ^ source/FluidPlug.c:148:26: error: incomplete definition of type 'struct _fluid_sfont_t' for (count = 0; sfont->iteration_next(sfont, &preset) != 0;) ~~~~~^ /usr/local/include/fluidsynth/types.h:40:16: note: forward declaration of 'struct _fluid_sfont_t' typedef struct _fluid_sfont_t fluid_sfont_t; /**< SoundFont */ ^ build log: https://ptpb.pw/Un0z