Bug 233618
| Summary: | cad/gmsh: Update to 4.0.6 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | kunda <luzpaz> | ||||
| Component: | Individual Port(s) | Assignee: | Joseph Mingrone <jrm> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | jrm, ndowens04, salvadore | ||||
| Priority: | --- | Keywords: | needs-patch, needs-qa | ||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| URL: | http://gmsh.info/CHANGELOG.txt | ||||||
| Attachments: |
|
||||||
|
Description
kunda
2018-11-28 19:52:03 UTC
(In reply to kunda from comment #0) Port is unmaintained. Can you provide a patch? I can't CC a couple of folks who may be able (but shouldn't feel compelled) to help, and previous MAINTAINER who may have spare cycles or be able to help understand what's needed or caveats to getting this updated. Will look at updating (In reply to Nathan from comment #4) Thanks Nathan :) Update: I have patch ready, it works on 13-current i386. I got to create a 12-386 jail to test and make sure it is either broken or not broken after update. (In reply to Nathan from comment #6) Correction, it builds fine in 12-i386, still waiting for 13-i386 to build all needed deps for clean jail Temporarily assign Nathan as he works on the update so he can update bug fields. Created attachment 199874 [details] Update ; Unmark broken on 12/13-i386 cad/gmsh: * Update to 4.0.6 * Unmark broken on 12/13-i386, built in poudriere * Correct order of variables, per handbook * Add missing LDCONFIG, installs shared libraries PR: 233618 Submitted by: Nathan <ndowens@yahoo.com> Approved by: portmgr (Unmaintained port) Dropping assignee, so committer can assign themselves. Comment on attachment 199874 [details]
Update ; Unmark broken on 12/13-i386
Portlint -AC: Looks fine
Poudriere 12/13 i386: Built fine
A commit references this bug: Author: jrm Date: Thu Dec 6 11:55:00 UTC 2018 New revision: 486753 URL: https://svnweb.freebsd.org/changeset/ports/486753 Log: cad/gmsh: Update to 4.0.6 Upstream change log: https://gitlab.onelab.info/gmsh/gmsh/blob/master/CHANGELOG.txt PR: 233618 Submitted by: ndowens@yahoo.com Reported by: chitty_cloud@me.com Changes: head/cad/gmsh/Makefile head/cad/gmsh/distinfo head/cad/gmsh/pkg-plist Committed. Thanks. On closer inspection, I don't think 'USE_LDCONFIG=yes' should have been added. I only see shared libraries installed when the SHARED knob is on and there is 'SHARED_VARS=USE_LDCONFIG=yes' Also, could elaborate on why 'MAKE_JOBS_UNSAFE=yes' was removed? (In reply to Joseph Mingrone from comment #14) MAKE_JOBS_UNSAFE was removed simply because it built fine without any issue on the targets I tested. Also do you want me to revise the USE_LDCONFIG. Could change to SHARED_USE= LDCONFIG (IF it exists, will have to look to make sure) (In reply to Nathan from comment #15) Woops, relooked at Makefile and it had LDCONFIG. Will remove Thanks for clarifying. No need to submit anything new. It's just one line to remove. MAKE_JOBS_UNSAFE is a bit of a black art. It can build find in specific cases, but other builds can still fail. Let's leave it out and see how things go. (In reply to Joseph Mingrone from comment #17) Sorry about the LDCONFIG line, didn't notice it when I added USE_LDCONFIG No worries. Neither did I. just a quick bump that 4.0.7 was just released http://gmsh.info/CHANGELOG.txt 4.0.7 (December 9, 2018): fixed small memory leaks; removed unused code. I will try to commit the update soon. 4.1.0 was just released. 4.1.0 (January 13, 2019): improved ONELAB and Fltk support in API; improved renumbering of mesh nodes/elements; major code refactoring. |
