Bug 233676
| Summary: | sysutils/node_exporter: build has no version | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Volodymyr Kostyrko <arcade> | ||||
| Component: | Individual Port(s) | Assignee: | freebsd-ports-bugs (Nobody) <ports-bugs> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | 0mp, ports | ||||
| Priority: | --- | Keywords: | needs-qa | ||||
| Version: | Latest | Flags: | bugzilla:
maintainer-feedback?
(ports) koobs: merge-quarterly? |
||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 234707 | ||||||
| Attachments: |
|
||||||
I know how to fix:
BUILD_USER?= ${USER}
LD_FLAG_X_PREFIX= -X ${GO_PKGNAME}/vendor/${GO_PKGNAME:H}/common/version
LD_FLAG_STRING= -s \
${LD_FLAG_X_PREFIX}.Version=${PORTVERSION} \
${LD_FLAG_X_PREFIX}.Revision=${PORTREVISION} \
${LD_FLAG_X_PREFIX}.Branch=release-${PORTVERSION:R} \
${LD_FLAG_X_PREFIX}.BuildUser=${BUILD_USER}
GO_BUILDFLAGS= -v -ldflags "${LD_FLAG_STRING}"
(In reply to Volodymyr Kostyrko from comment #1) Could you provide a unified diff to the port as an attachment please Created attachment 200331 [details]
patch to add version
Taken from prometheus port, actually.
Committed in #489681. https://svnweb.freebsd.org/ports?view=revision&revision=489681 |
Hello. Currently I have this: > node_exporter --version node_exporter, version (branch: , revision: ) build user: build date: go version: go1.11.1 It makes it hard to track unupdated hosts for example.