|Summary:||sysutils/burp: Update to 2.1.32|
|Product:||Ports & Packages||Reporter:||Fabio Prina <fabio.prina>|
|Component:||Individual Port(s)||Assignee:||Bradley T. Hughes <bhughes>|
|Severity:||Affects Only Me||CC:||bhughes, ndowens, phascolarctos|
|Bug Depends on:|
Description Fabio Prina 2018-12-03 21:34:38 UTC
The present 1.4.40 is no more the BURP stable release since 2016-12-02. The current stable is the 2.1.32 dated april 2018 https://burp.grke.org/download.html Could you please update the port to the new version. Thanks -- Fabio
Comment 1 Kubilay Kocak 2018-12-04 05:41:02 UTC
Thank you for your request Fabio. This port does not currently have a maintainer, so tested  patches to update the port will be needed to resolve this issue. If you can provide a tested  patch that would be great. Note that upstream calls the 2.1.x branch 'stable', but there is also a 2.2.x 'latest' release series. Since this is an update of 1.4.x to 2.x.x, I also note upstream has a warning and recommendation for protocol v1 vs 2: - https://burp.grke.org/protocol2.html [warning] - https://burp.grke.org/protocol1.html [recommendation] The default/sample configuration file (if provided, and one should be) should likely default to protocol1 if it is not the default.  https://www.freebsd.org/doc/en/books/porters-handbook/testing.html
Comment 2 Fabio Prina 2018-12-04 09:51:09 UTC
Thanks to you for your reply Kubilay, The branch 2.2.x is the develop/bleeding edge, often monthly based, version so to be conservative I think it's better port the stable one. Unfortunately I'm not a real FreeBSD user, I use it in few specific projects so at the moment I'm not able to provide a tested patch... anyway I can study "how to" and try I'll let you know as soon as possible. PS: I do not know which protocol is the default, the manual tell "automatically decides based on the (server|client) version"; I usually force the v1 in the configuration files so I completely agree with you.
Comment 3 Lorenzo Salvadore 2018-12-04 10:08:54 UTC
(In reply to Fabio Prina from comment #2) I can do the work for you, if you prefer.
Comment 4 Fabio Prina 2018-12-04 10:19:59 UTC
(In reply to Lorenzo Salvadore from comment #3) If you can I'll be grateful for your help; this will speed up the resolution of "my problem"
Comment 5 Kubilay Kocak 2018-12-04 12:06:30 UTC
(In reply to Lorenzo Salvadore from comment #3) Thanks Lorenzo :)
Comment 6 Lorenzo Salvadore 2018-12-04 19:22:21 UTC
Created attachment 199825 [details] burp update to 2.1.32 Here is the update. This is the update to 2.1.32, which according to Fabio is to be considered the stable version. In a few minutes I will open a new bug report with a new port called burp-devel, which will keep track of the latest version (2.2.12): I will give the bug report number here. The burp-devel port is obtained from burp as a slave port. Someone with the rights to do it should change the summary of this bug report with the correct version number. Changelogs for burp can be found here: https://burp.grke.org/changelog.html Keep in mind that last version we had in the ports tree was 1.4.40. Some details about how I changed the port's Makefile: - Defines PORTVERSION through ?=, so that the slave port burp-devel can overwrite it with its own value. - Resets PORTREVISION, since PORTVERSION has been increased. - Sets myself as MAINTAINER (I adopt the port). - Adds needed dependency on devel/yajl. - Reorders variables consistently with the official order. - Removes uneeded stuff (uneeded targets, patchs, variables...). - Defines INSTALL_TARGET= install-all to make sure that configuration files are installed (they will not be installed without). Everything has been tested successfully with portlint and poudriere (11.2-RELEASE-p5 i386/amd64).
Comment 8 Lorenzo Salvadore 2018-12-04 19:44:54 UTC
Created attachment 199828 [details] burp update to 2.1.32, correction 1 Sorry, forgot to define CONFLICTS_INSTALL. Now the master port conflicts with the slave port.
Comment 9 Fabio Prina 2018-12-04 21:46:53 UTC
(In reply to Lorenzo Salvadore from comment #6) Summary version number changed Thanks again Lorenzo
Comment 10 Lorenzo Salvadore 2018-12-21 11:28:15 UTC
Now tested successfully with poudriere on 12.0-RELEASE i386/amd64 too.
Comment 11 commit-hook 2019-03-22 22:04:26 UTC
A commit references this bug: Author: bhughes Date: Fri Mar 22 22:04:07 UTC 2019 New revision: 496596 URL: https://svnweb.freebsd.org/changeset/ports/496596 Log: sysutils/burp: Update 1.4.40_3 -> 2.1.32 Bump to the latest stable version. Submitter takes maintainership. PR: 233758 Submitted by: firstname.lastname@example.org (maintainer) Reported by: email@example.com Sponsored by: Miles AS Changes: head/sysutils/burp/Makefile head/sysutils/burp/distinfo head/sysutils/burp/files/patch-src_server.c head/sysutils/burp/pkg-plist
Comment 12 Bradley T. Hughes 2019-03-22 22:05:29 UTC
Committed, thanks! I wonder if it would be appropriate to write something for UPDATING, in case users of burp 1.x need to do something special when upgrading?