Summary: | cad/z88: Update to v15 | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | kunda <luzpaz> | ||||
Component: | Individual Port(s) | Assignee: | Kurt Jaeger <pi> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Only Me | CC: | ndowens04, pi, salvadore | ||||
Priority: | --- | ||||||
Version: | Latest | ||||||
Hardware: | Any | ||||||
OS: | Any | ||||||
Attachments: |
|
Description
kunda
2018-12-04 11:52:26 UTC
I will try to update the port. Created attachment 199912 [details]
z88 update to 15 patch
Here is the patch for z88. I did not find a changelog for the software.
Here is a summary of the changes made to the port.
- Changes PORTVERSION to DISTVERSION. I have checked that PORTVERSION keeps increasing.
- Sets myself as MAINTAINER.
- Uses USE_GITHUB instead of MASTER_SITES (I find it easier to maintain).
- Sets LICENSE.
- Sets appropriate dependencies, USES, USE_X.
- Adds an EXAMPLES option.
- Adds a pkg-message to explain how the port must be used, as it is not self-evident (The software assumes all files in the same directory instead of distributed into bin/, ${DATADIR} etc so I had to find a work around: the solution is easy for the user).
Portlint remarks that some of my patches contains ^M characters and suggests the use of USE+=dos2unix. I refrained to do that because this concerns only some files in the working directory while installed files should be clean, so I thought it was better to keep the port simple.
Tested successfully with poudriere (11.2-RELEASE-p6 i386/amd64).
(In reply to Lorenzo Salvadore from comment #2) That was fast! Thank you Lorenzo! You're welcome. Now tested successfully with poudriere on 12.0-RELEASE i386/amd64 too. (In reply to Lorenzo Salvadore from comment #4) Fantastic! Will this patch be merged ? testbuilds@work Committed, thanks! A commit references this bug: Author: pi Date: Mon Dec 31 13:33:58 UTC 2018 New revision: 488785 URL: https://svnweb.freebsd.org/changeset/ports/488785 Log: cad/z88: update 13.0 -> 15 - Changes PORTVERSION to DISTVERSION - Sets submitter as MAINTAINER. - Uses USE_GITHUB instead of MASTER_SITES - Sets LICENSE - Sets appropriate dependencies, USES, USE_X - Adds an EXAMPLES option - Adds a pkg-message to explain how the port must be used, as it is not self-evident (The software assumes all files in the same directory instead of distributed into bin/, ${DATADIR} etc so I had to find a work around: the solution is easy for the user). PR: 233772 Submitted by: Lorenzo Salvadore <phascolarctos@protonmail.ch> Reviewed by: chitty_cloud@me.com Relnotes: https://forum.z88.de/viewtopic.php?f=18&t=885 Changes: head/cad/z88/Makefile head/cad/z88/distinfo head/cad/z88/files/patch-bin_unix64_z88.fcd head/cad/z88/files/patch-cb88o.c head/cad/z88/files/patch-ccos head/cad/z88/files/patch-dyn88v.c head/cad/z88/files/patch-make_make__unix__64_z88com.mk.gcc64 head/cad/z88/files/patch-make_make__unix__64_z88g.mk.gcc64 head/cad/z88/files/patch-make_make__unix__64_z88n.mk.gcc64 head/cad/z88/files/patch-make_make__unix__64_z88o.mk.gcc64 head/cad/z88/files/patch-make_make__unix__64_z88r.mk.gcc64 head/cad/z88/files/patch-make_make__unix__64_z88x.mk.gcc64 head/cad/z88/files/patch-src_z88o_unix_cb88o.c head/cad/z88/files/patch-z88.fcd head/cad/z88/files/patch-z88.mk.gtk.gcc32 head/cad/z88/files/patch-z88.mk.kernel.gcc32 head/cad/z88/files/patch-z88.mk.other.gcc32 head/cad/z88/files/z88 head/cad/z88/files/z88.sh head/cad/z88/pkg-message head/cad/z88/pkg-plist |