Bug 233777
| Summary: | security/softhsm2: Fails to build with OpenSSL 1.1.x / LibreSSL | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Sergey Akhmatov <sergey> | ||||||||
| Component: | Individual Port(s) | Assignee: | Niclas Zeising <zeising> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Some People | CC: | jaap, jhb, zeising | ||||||||
| Priority: | --- | Keywords: | needs-qa, patch | ||||||||
| Version: | Latest | Flags: | jaap:
maintainer-feedback+
koobs: merge-quarterly? |
||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 231931 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Sergey Akhmatov
2018-12-04 15:40:25 UTC
Created attachment 199821 [details]
softhsm2 fix with non-base openssl
Updated patch, missed "USES= ssl" which makes "CRYP_OPEN_USES= ssl" useless, remove it.
(In reply to Sergey Akhmatov from comment #1) The patch seems to work fine, tested on multiple releases (using poudriere). Approved. Small issue, the committer might want to raise the PORTREVISON. jaap @jaap please use the maintainer-approval flag (+) to declare acceptance/approval of a patch (attachment). If you'd like a new patch for PORTREVISION, it would also be less confusing not to accept it, though this likely doesn't require one as it appears to only fix broken builds. (In reply to Kubilay Kocak from comment #3) Some committers want to see a revision bump for small changes like this, others remove a revision dump when I do one so it was more a question then anything else. But go ahead with this patch (maintainer flag is set). (In reply to jaap from comment #4) I understand. Either way you can set the maintainer-approval flag (on attachments) to +. You can do this with: Attachment -> Details -> maintainer-approval [+] to signify approval/acceptance This is different from the maintainer-feedback flag, which is just to acknowledge/provide general feedback (at the issue level, not on patches) (In reply to Kubilay Kocak from comment #5) Didn't realise there was a separate flag for attachments. It is now set Is this still needed and just waiting for a ports committer to merge the approved patch? (In reply to John Baldwin from comment #7) Yes please, the patch is still needed (I just tested). I will add an updated patch which includes the proposed revision bump. Created attachment 205486 [details]
improved patch
As promised, this patch has the revision bump included
A commit references this bug: Author: zeising Date: Tue Jul 2 20:45:36 UTC 2019 New revision: 505706 URL: https://svnweb.freebsd.org/changeset/ports/505706 Log: security/softhsm2: Fix build with non-base openSSL PR: 233777 Submitted by: Sergey Akhmatov Approved by: Jaap Akkerhuis (maintainer) Changes: head/security/softhsm2/Makefile head/security/softhsm2/files/patch-src_lib_crypto_OSSLCryptoFactory.cpp Committed, thanks! |
