Bug 233840

Summary: archivers/dpkg: fix build with GCC-based architectures
Product: Ports & Packages Reporter: Piotr Kubaj <pkubaj>
Component: Individual Port(s)Assignee: Steve Wills <swills>
Status: Closed FIXED    
Severity: Affects Only Me CC: linimon, ndowens04
Priority: --- Flags: bugzilla: maintainer-feedback? (ndowens04)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch ndowens04: maintainer-approval+

Description Piotr Kubaj freebsd_committer freebsd_triage 2018-12-06 23:57:39 UTC
Created attachment 199914 [details]
patch

This port requires USES=compiler:c11 to build on GCC architectures.

Tested on powerpc64 and amd64.

Hardware sponsored by IntegriCloud.
Comment 1 Nathan 2018-12-07 00:11:35 UTC
(In reply to Piotr Kubaj from comment #0)
Which archs? I do not want to target every arch
Comment 2 Piotr Kubaj freebsd_committer freebsd_triage 2018-12-07 00:17:51 UTC
(In reply to Nathan from comment #1)
powerpc64 for sure, but errors like in https://talos.anongoth.pl/data/powerpc64-default/2018-12-05_22h39m09s/logs/errors/dpkg-1.19.2.log
method.h:65: error: expected ';' before 'override'In file included from pkgdepcon.cc:32:
pkglist.h:152: error: expected ';' before 'override'
pkglist.h:153: error: expected ';' before 'override'
pkglist.h:154: error: expected ';' before 'override'
pkglist.h:155: error: expected ';' before 'override'
pkglist.h:156: error: expected ';' before 'override'

are not architecture-dependant. I know you care about mips*, but this port probably won't build anyway on any platform with base GCC.
Comment 3 Nathan 2018-12-07 00:19:21 UTC
I can't + patch since there is no maintainer ? flag
Comment 4 Nathan 2018-12-07 00:23:14 UTC
Hoping to have newer GCC working on mips*, so approving
Comment 5 Mark Linimon freebsd_committer freebsd_triage 2018-12-07 01:07:53 UTC
(In reply to Nathan from comment #4)

fwiw, dpkg is Debian-specific and AFAIK we have no support for mips in our Linux emulation code.
Comment 6 commit-hook freebsd_committer freebsd_triage 2018-12-09 03:00:16 UTC
A commit references this bug:

Author: swills
Date: Sun Dec  9 02:59:56 UTC 2018
New revision: 487014
URL: https://svnweb.freebsd.org/changeset/ports/487014

Log:
  archivers/dpkg: fix build with GCC-based architectures

  PR:		233840
  Submitted by:	Piotr Kubaj <pkubaj@anongoth.pl>
  Approved by:	Nathan <ndowens@yahoo.com> (maintainer)

Changes:
  head/archivers/dpkg/Makefile
Comment 7 Steve Wills freebsd_committer freebsd_triage 2018-12-09 03:01:03 UTC
Committed, thanks!