Bug 233843
| Summary: | sysutils/logstash5: logstash-plugin binary is not executable | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Sven Ruediger <admin> | ||||||
| Component: | Individual Port(s) | Assignee: | freebsd-elastic (Nobody) <elastic> | ||||||
| Status: | Closed Overcome By Events | ||||||||
| Severity: | Affects Many People | CC: | dvl, otis, w.schwarzenfeld | ||||||
| Priority: | --- | Keywords: | easy, needs-patch, needs-qa | ||||||
| Version: | Latest | Flags: | dvl:
maintainer-feedback+
koobs: merge-quarterly? |
||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
If a better alternate method within the context of the build system (such as a bug fix) is not possible/feasable, the workaround the manually modify the executables permissions should:
- Use the ${CHMOD} variable provided by the framework
- Use ${LOCALBASE} / PREFIX-safe variable for the path
- Happen at post-install: stage (in STAGEDIR}
However, the port already includes the following block in do-install:
for x in ${LOGSTASH_BIN_FILES}
@${CHMOD} ${BINMODE} ${STAGEDIR}${LOGSTASH_DIR}/bin/${x}
But LOGSTASH_BIN_FILES only contains 'logstash'
The sysutils/logstash6 port takes a more robust approach, but chmod'ing all binaries in the path:
${CHMOD} ${BINMODE} ${STAGEDIR}${LOGSTASH_DIR}/bin/*
I recommend taking the latter (logstash6) approach in this port.
Comment on attachment 199921 [details]
Makefile patch
--- Makefile.old 2018-12-07 08:34:05.078672000 +0100
+++ Makefile 2018-12-07 09:26:14.080053000 +0100
@@ -43,9 +43,7 @@
${MKDIR} ${STAGEDIR}${ETCDIR}
@(cd ${WRKSRC} && ${COPYTREE_SHARE} . ${STAGEDIR}${LOGSTASH_DIR})
${INSTALL_DATA} ${FILESDIR}/logstash.conf.sample ${STAGEDIR}${ETCDIR}
-.for x in ${LOGSTASH_BIN_FILES}
- @${CHMOD} ${BINMODE} ${STAGEDIR}${LOGSTASH_DIR}/bin/${x}
-.endfor
+ ${CHMOD} ${BINMODE} ${STAGEDIR}${LOGSTASH_DIR}/bin/*
.for x in ${LOGSTASH_JRUBY_BIN_FILES}
@${CHMOD} ${BINMODE} ${STAGEDIR}${LOGSTASH_DIR}/${LOGSTASH_JRUBY_SUBDIR}/${x}
.endfor
Thanks for the help. The Logstash5 approach (for loop) doesn't work. [...] -r-xr-xr-x 1 root wheel 2511 Feb 16 2018 logstash -rw-r--r-- 1 root wheel 448 Feb 16 2018 logstash-plugin -rw-r--r-- 1 root wheel 5400 Feb 16 2018 logstash.lib.sh [..] The Logstash6 approach fixes that. New patch is attached. Created attachment 199925 [details]
Makefile patch (Logstash6 approach)
Maintainer feedback! maintainer approved. Might as well also delete LOGSTASH_BIN_FILES definition. This port is no longer actively maintained and is scheduled for removal. |
Created attachment 199921 [details] Makefile patch Hi, /usr/local/logstash/bin/logstash-plugin ist not executable after installation. Might be fixed in during post-install, suggested patch attached. Thanks Sven