Bug 233889

Summary: [NEW PORT] comms/ath3k-firmware Atheros AR3011/AR3012 bluetooth adaptor firmwares used by ath3kfw(8)
Product: Ports & Packages Reporter: Vladimir Kondratyev <wulf>
Component: Individual Port(s)Assignee: Vladimir Kondratyev <wulf>
Status: Closed FIXED    
Severity: Affects Some People CC: adrian, wulf
Priority: --- Keywords: feature, needs-qa
Version: LatestFlags: koobs: maintainer-feedback? (wulf)
Hardware: Any   
OS: Any   
URL: https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git
Attachments:
Description Flags
ath3k-firmware.patch
none
ath3k-firmware.patch
none
poudriere build log none

Description Vladimir Kondratyev freebsd_committer freebsd_triage 2018-12-09 14:01:33 UTC 
Created attachment 199981 [details]
ath3k-firmware.patch

Firmware for the Atheros AR3011/AR3012 chip based Bluetooth USB devices.
To be downloaded with ath3kfw(8).

WWW: https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git
Comment 1 Vladimir Kondratyev freebsd_committer freebsd_triage 2018-12-09 15:48:48 UTC 
portlint, make stage-qa  and make check-plist output:

$ portlint -a
WARN: Makefile: using hyphen in PORTNAME. consider using PKGNAMEPREFIX and/or PKGNAMESUFFIX.
0 fatal errors and 1 warning found.

$ make stage-qa   
====> Running Q/A tests (stage-qa)
/!\ To run stage-qa automatically add DEVELOPER=yes to your environment /!\

$ make check-plist
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
===> Checking for items in pkg-plist which are not in STAGEDIR
===> No pkg-plist issues found (check-plist)
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2018-12-15 03:08:06 UTC 
@Vladimir Can you include the relevant (SUBDIR) addition of the port in comms/Makefile please, and confirm that this passes QA (poudriere, make.conf:DEVELOPER=yes)

The patch looks OK, and I'm happy to accept (ports) on the basis of the above changes and confirmation.
Comment 3 Vladimir Kondratyev freebsd_committer freebsd_triage 2018-12-15 13:49:19 UTC 
Created attachment 200133 [details]
ath3k-firmware.patch

Some tweaks:

1. "SUBDIR += ath3k-firmware" line was added to comms/Makefile
2. portscout hint is added
3. LICENSE_PERMS is changed from "no-dist-sell no-pkg-sel" to "dist-sell pkg-sel"
License explicitly "grants a ... license ... to sell ("Utilize") this software ... in conjunction with an Atheros Chipset"
Comment 4 Vladimir Kondratyev freebsd_committer freebsd_triage 2018-12-15 13:50:37 UTC 
Created attachment 200134 [details]
poudriere build log
Comment 5 commit-hook freebsd_committer freebsd_triage 2019-02-15 21:32:31 UTC 
A commit references this bug:

Author: wulf
Date: Fri Feb 15 21:31:35 UTC 2019
New revision: 493009
URL: https://svnweb.freebsd.org/changeset/ports/493009

Log:
  New port: comms/ath3k-firmware

  Firmware for the Atheros AR3011/AR3012 chip based Bluetooth USB devices.
  To be downloaded with ath3kfw(8).

  WWW: https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git

  PR:		233889
  Approved by:	koobs

Changes:
  head/comms/Makefile
  head/comms/ath3k-firmware/
  head/comms/ath3k-firmware/Makefile
  head/comms/ath3k-firmware/distinfo
  head/comms/ath3k-firmware/files/
  head/comms/ath3k-firmware/files/ath3k.conf.in
  head/comms/ath3k-firmware/pkg-descr
  head/comms/ath3k-firmware/pkg-plist