Bug 233909
| Summary: | security/py-certbot: Incorrect config file path since update to 0.29.1 | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Matthew Seaman <matthew> | ||||||||
| Component: | Individual Port(s) | Assignee: | Matthew Seaman <matthew> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Many People | CC: | koobs, python, vivek, yasu | ||||||||
| Priority: | Normal | Flags: | koobs:
maintainer-feedback+
|
||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| See Also: | https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227289 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Matthew Seaman
2018-12-10 15:38:18 UTC
My hack-around was to symlink /etc/letsencrypt to point to /usr/local/etc/letsencrypt. Once this is fixed, anyone who configured it during this time will have to move their configs to /usr/local/etc. Created attachment 200016 [details]
Fix setting FreeBSD specific paths
Needs testing. I'll be running this patch for my usual LetsEncrypt periodic jobs overnight.
Patches updated by `make makepatch` Needs testing. I'll be running this for my overnight periodic jobs tonight. @Matthew Thanks for the patch Longer term we might want to ship a default cli.ini Hmmm... I should add DragonFLY support too. What does sys.platform look like on DFLY? While I'm -0 on supporting other OS's within FreeBSD ports, it appears [1][2] the value starts with dragonfly. See Also: https://docs.python.org/2/library/sys.html#sys.platform In particular: For most Unix systems, this is the lowercased OS name as returned by uname -s with the first part of the version as returned by uname -r appended, e.g. 'sunos5', at the time when Python was built [1] https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1707 [2] google: sys.platform.startswith("dragonfly"): Created attachment 200033 [details]
Fix setting FreeBSD specific paths
Add DFLY support too
(In reply to Matthew Seaman from comment #7) Hello Matthew, Index: files/patch-certbot_compat.py =================================================================== --- files/patch-certbot_compat.py (nonexistent) +++ files/patch-certbot_compat.py (working copy) @@ -0,0 +1,32 @@ +--- certbot/compat.py.orig 2018-12-05 23:47:58 UTC ++++ certbot/compat.py +@@ -183,6 +183,11 @@ LINUX_DEFAULT_FOLDERS = { + 'work': '/var/lib/letsencrypt', + 'logs': '/var/log/letsencrypt', + } ++FREEBSD_DEFAULT_FOLDERS = { ++ 'config': '%%LOCALBASE%%/letsencrypt', ^^^^^^^^^^^^^^^^^^^^^^^^^^^ This should be '%%LOCALBASE%%/etc/letsencrypt'. (In reply to Yasuhiro KIMURA from comment #8) Good catch. Thanks. Created attachment 200041 [details]
Fix setting FreeBSD specific paths
This is working fine for me, and I've had reports of success from other users. Can I get approval from python@ to commit? Comment on attachment 200041 [details] Fix setting FreeBSD specific paths Approved by: koobs (python) @Matthew could you please add a comment to the patch header pointing to this bug, like: # Incorrect config file path since update to 0.29.1 # https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=233909 # TODO: Upstream A commit references this bug: Author: matthew Date: Fri Dec 14 09:18:34 UTC 2018 New revision: 487414 URL: https://svnweb.freebsd.org/changeset/ports/487414 Log: Fix setting FreeBSD specific paths since upstream change https://github.com/certbot/certbot/commit/a23d76beb0e2c9539670766045314a5d50f582a2#diff-64ccdc74e8a07f9b039a6254093f1d0d as part of the update to 0.29.1 PR: 233909 Reported by: Paul Macdonald Approved by: koobs (python) Changes: head/security/py-certbot/Makefile head/security/py-certbot/files/patch-certbot_compat.py head/security/py-certbot/files/patch-setup.py Committed |