Bug 233963
| Summary: | net/miniupnpd: Fails to build when CHECK_PORTINUSE option enabled | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | ncrogers | ||||||||||||
| Component: | Individual Port(s) | Assignee: | Kurt Jaeger <pi> | ||||||||||||
| Status: | Closed FIXED | ||||||||||||||
| Severity: | Affects Some People | CC: | franco, ndowens04, pi, razzfazz, squat, w.schwarzenfeld | ||||||||||||
| Priority: | --- | Flags: | pi:
maintainer-feedback+
koobs: merge-quarterly? |
||||||||||||
| Version: | Latest | ||||||||||||||
| Hardware: | amd64 | ||||||||||||||
| OS: | Any | ||||||||||||||
| Attachments: |
|
||||||||||||||
(In reply to ncrogers from comment #0) Did you use any options other than default? Yes I believe so, the options in place are listed in the attached log file. I have these knobs in make.conf. net_miniupnpd_SET=LEASEFILE PF_FILTER_RULES IPV6 CHECK_PORTINUSE (In reply to ncrogers from comment #2) For now, I can tell you it is the portinuse option patch-portinuse.c needs to be disabled for FreeBSD < 12.0, it was repaired for 12.0 and up but broken for 11.x and below in March. Created attachment 204319 [details]
svn-diff-miniupnpd
Created attachment 204320 [details]
svn-diff-miniupnpd_v2
Was a typo in it.
Looks good so far, although the following idiom shall be used to avoid breaking foreign port trees:
.if ${OPSYS} == FreeBSD && ${OSVERSION} >= XXX
Cheers,
Franco
Created attachment 204321 [details]
svn-diff-miniupnpd_v3
Okay!
Thanks, one more thing I noticed is that bumping PORTEPOCH was probably unintended. Since this is a build fix no bump for PORTREVISION is needed as well. And can we have this committed please? :) Cheers, Franco Created attachment 209047 [details]
patch v4
working patch which fixes two issues in previous
Looks ok for me testbuilds@work Committed, thanks! A commit references this bug: Author: pi Date: Mon Dec 16 08:13:39 UTC 2019 New revision: 520227 URL: https://svnweb.freebsd.org/changeset/ports/520227 Log: net/miniupnpd: Fix build when CHECK_PORTINUSE option enabled PR: 233963 Reported by: ncrogers@gmail.com Submitted by: w.schwarzenfeld@utanet.at Reviewed by: franco@opnsense.org Approved by: squat@squat.no (maintainer) Changes: head/net/miniupnpd/Makefile head/net/miniupnpd/files/extra-patch-portinuse.c head/net/miniupnpd/files/patch-portinuse.c |
Created attachment 200061 [details] poudriere log miniupnpd fails to build under 12.0-RELEASE. poudriere log is attached.