Bug 233985
| Summary: | www/dillo2: Fails to build with OpenSSL 1.1.1 on FreeBSD 12+ (No libssl found. Disabling ssl support.) | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Justin Hibbits <jhibbits> | ||||||||
| Component: | Individual Port(s) | Assignee: | freebsd-ports-bugs (Nobody) <ports-bugs> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Some People | CC: | salvadore | ||||||||
| Priority: | --- | Keywords: | needs-patch, needs-qa | ||||||||
| Version: | Latest | Flags: | koobs:
merge-quarterly?
|
||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| URL: | http://cvsweb.netbsd.org/bsdweb.cgi/pkgsrc/www/dillo/patches/ | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 231931 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Justin Hibbits
2018-12-13 16:39:30 UTC
Nathan believes he has a patch, temporarily assign so he can re-triage/assign when done. Created attachment 200101 [details] Fix OpenSSL 1.1.x build ; add missing linked libraries www/dillo2: * Add patches from NetBSD conditionally, fix OpenSSL 1.1x when SSL is enabled * Add missing libraries link, listed in stage-qa PR: 233985 Submitted by: Nathan <ndowens@yahoo.com> Approved by: portmgr (Unmaintained port) Created attachment 200102 [details]
Fix OpenSSL 1.1.x build ; add missing linked libraries
Fix mis-wording in commit message
Created attachment 200103 [details]
Fix OpenSSL 1.1.x build ; add missing linked libraries
Fix alignment issues
Comment on attachment 200103 [details]
Fix OpenSSL 1.1.x build ; add missing linked libraries
Approved by: portmgr (unmaintained port)
Thank you Nathan. Please clarify/confirm: - Did this pass testing with *all of* Base OpenSSL (< 12), OpenSSL 1.1.0 and 1.1.1 ? Also a review item: - LIB_DEPENDS: one per line with \ line terminators - SSL option description removal not explained. Is it no longer experimental per upstream? - How did libpng / x* bits end up linked if not depended on in this port in the current version? Does a dependency install them? Are there configure options for png/x-bits we should explicitly be using to enable/disable detection? See also bug #238356, where I merged a similar patch created by myself with the one here proposed. I maintain original SSL_DESC. The dependecies for png and jpeg could be disabled through configure, but my patch does not do that (yet); I just fixed the missing library through stage-qa from poudriere, like ndowens seems to have done. Maybe it would be the case to close one of the two bugs for duplication. A commit references this bug: Author: swills Date: Fri Jun 7 23:52:20 UTC 2019 New revision: 503677 URL: https://svnweb.freebsd.org/changeset/ports/503677 Log: www/dillo2: various improvements and adoption [1] - Refresh distinfo [1] - Fix SSL [2] - Add missing dependencies [1] - Assign maintainer to submitter [1] - Make PNG and JPEG support optional [1] PR: 238356 [1] PR: 233985 [2] Submitted by: Lorenzo Salvadore <phascolarctos@protonmail.ch> [1] Submitted by: Nathan <ndowens@yahoo.com> [2] Reported by: tigersharke@gmail.com [1] Reported by: jhibbits [2] Changes: head/www/dillo2/Makefile head/www/dillo2/distinfo head/www/dillo2/files/ head/www/dillo2/files/extra-patches-openssl Committed, thanks! |
