Bug 234007

Summary: [NEW PORT] irc/bitlbee-discord: Discord plugin for bitlbee
Product: Ports & Packages Reporter: Arthur Pirika <arfy32>
Component: Individual Port(s)Assignee: Tobias Kortkamp <tobik>
Status: Closed FIXED    
Severity: Affects Only Me CC: arfy32, michiel, ndowens04
Priority: --- Keywords: feature, needs-qa
Version: LatestFlags: arfy32: maintainer-feedback+
Hardware: Any   
OS: Any   
Description Flags
new diff, with suggested changes to placement of variables. none

Description Arthur Pirika 2018-12-14 09:37:21 UTC
Created attachment 200109 [details]

An alternative plugin for bitlbee that allows connections to the discord chat service. Does not require use of libpurple. My first port! Comment and constructive criticism welcome!
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2018-12-14 10:03:06 UTC
Great job for a first timer Arthur, well done!

At a cursory view, the changes look OK.

What you'll want to do from here is get your QA game on, so you can be confident about any this and future contributions before you submit them, to pick up issues early and often and to save time going back and forth on Bugzilla issues for issues tooling can objectively identify.

Check out the following section in the Porters Handbook, which goes over the details and instructions for the tools we use to test ports. In particular (and in summary) you'll want to use:

- portlint
- poudriere
- DEVELOPER=yes in /etc/make.conf (and poudriere's make.conf's)

If you have any questions, get stuck or need anything else, hit us up at #freebsd-ports on freenode IRC.
Comment 2 Michiel van Baak 2018-12-14 10:26:17 UTC
Nice, thank you.

I compiled and installed the port on a fresh 12.0 machine with the bitlbee package installed using pkg.
Port compiles, installs and works great.
Comment 3 Arthur Pirika 2018-12-14 10:36:23 UTC
(In reply to Kubilay Kocak from comment #1)
Hi, thanks for the feedback! I had already done a portlint and a poudriere test run for my current arch, AMD64 12-0-RELEASE before submitting the patch, however was about to start testing for AMD64 11.2-RELEASE, the previous production release, and 12.0 and 11.2 releases for i386. It takes quite a while here as I'm doing all this in a virtual machine, I know, not the best environment for development! Thanks also for the reminder to enable DEVELOPER="yes", too!
Is this the test procedure, test to ensure the port runs on the current production releases for both AMD64 and i386?
Comment 4 Arthur Pirika 2018-12-14 10:38:56 UTC
(In reply to Michiel van Baak from comment #2)
Hi, glad I could help! I'm still considering this alpha, however happy that it works for you. I'm also running this from my port on my own machine here, too.
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2018-12-14 10:46:48 UTC
(In reply to Arthur Pirika from comment #3)

VM's are perfectly fine (I do mine in a virtualbox CURRENT guest), and its good to know you've run through portlint/poudriere. For future issues, its always good to mention this explicitly, so there's no questions or ambiguity, like:

portlint: OK (looks fine.)
testport: OK (poudriere: <versions, archs> tested)

Unless the software has a test suite, and the port has TEST_DEPENDS (if necessary) and a test: target to run the tests, poudriere (in various architecture/version jails) basically tests everything up to and including packaging (fetch, configure build, install), but not runtime, which is why test suite integration is fantastic if upstream provides them. You can mention this in your issues, like:

maketest: OK (XXX of YYY tests: PASS)

For some mode 101/cheatsheets/guidelines on Porting/Bugzilla/Workflow:

 * https://wiki.freebsd.org/KubilayKocak/ThePerfectPortsIssue
 * https://wiki.freebsd.org/KubilayKocak/Bugzilla/DosAndDonts
Comment 6 Arthur Pirika 2018-12-15 02:22:18 UTC
QA update. The following testing has now been done on this port.

make check-orphans: OK
make stage: OK
make package, as root: OK
make package, as user: OK
make install, in running system: OK
make deinstall, in running system: OK
portlint: Trivial warnings, no errors. 
Poudriere runs: all successfull for the following architecture/version combos.
i386 /11.2-release, i386/12.0-release
Note: I have not tested amd64/11.2-release, as this port takes nearly 5 hours for me to compile, thanks to a dependency on llvm60 that's pulled in during the build process for *each* build! Also, I'm confident that 11.2-release on amd64 will work, as this is where I began the project. 

Hope port committers find this useful!
Comment 7 Nathan 2018-12-15 03:05:26 UTC
Comment on attachment 200109 [details]

+USES=		autoreconf gettext-runtime libtool pkgconfig
+USE_GNOME=	glib20
+GH_ACCOUNT=	sm00th

I would have it something like:
USES=		autoreconf gettext-runtime libtool pkgconfig
USE_GNOME=	glib20
GH_ACCOUNT=	sm00th


For one, it keeps the USES* together, second typically suppose to be a new line after USES, GH_* can be put right below USE_GITHUB.
Comment 8 Nathan 2018-12-15 03:06:04 UTC
(In reply to Nathan from comment #7)
By USES, I meant USES* block
Comment 9 Arthur Pirika 2018-12-16 04:30:48 UTC
Created attachment 200142 [details]
new diff, with suggested changes to placement of variables.
Comment 10 Tobias Kortkamp freebsd_committer 2019-01-25 08:04:11 UTC
(In reply to Arthur Pirika from comment #6)
> Hope port committers find this useful!

Yes, thank you!
Comment 11 commit-hook freebsd_committer 2019-01-25 08:05:02 UTC
A commit references this bug:

Author: tobik
Date: Fri Jan 25 08:04:02 UTC 2019
New revision: 491132
URL: https://svnweb.freebsd.org/changeset/ports/491132

  New port: irc/bitlbee-discord

  Bitlbee plugin to allow connections to the discord chat service.
  A more lightweight alternative to using bitlbee compiled with
  libpurple support.

  WWW: https://github.com/sm00th/bitlbee-discord

  PR:		234007
  Submitted by:	Arthur Pirika <arfy32@gmail.com>
  Reviewed by:	koobs, ndowens@yahoo.com