Bug 234288
| Summary: | devel/trio broken | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Mikhail Teterin <mi> | ||||
| Component: | Individual Port(s) | Assignee: | Rodrigo Osorio <rodrigo> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | freebsd-2024 | ||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(rodrigo) |
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
A commit references this bug: Author: rodrigo Date: Fri Dec 28 14:03:34 UTC 2018 New revision: 488600 URL: https://svnweb.freebsd.org/changeset/ports/488600 Log: Fix multiple issues in devel/trio * unbreak the port in the tier architectures * add a bsd makefile to build and install the port instead of a gnu makefile * run the author regression test as part of the build process * do the proper changes to be able to disable the documentation The new generated lib is named libtrio.so.2 ( previously misnamed libtrio.so.2.0.0) and the libtrio.so symlink is generated. An entry in the UPDATING file was added about those changes Bump portrevision. PR: 234288 Submitted by: mi Changes: head/UPDATING head/devel/trio/Makefile head/devel/trio/files/BSDmakefile head/devel/trio/files/patch-Makefile.in head/devel/trio/files/patch-regression.c head/devel/trio/pkg-plist committed thanks. I didn't remove the documentation because I think it's useful to have it and has size cost is so small. Thanks. You may wish to also reach out to the author regarding our need to patch the regression.c |
Created attachment 200384 [details] Improve devel/trio The current version of the port has a number of problems: 1) The shared library is misnamed (libtrio.so.2.0.0) 2) There is no shlib symlink installed, so ports LIB_DEPENDing on trio (such as graphics/GraphicsMagick) break 3) The shared library is created EMPTY - none of the compiled shared objects are put into it 4) The static library is built from files compiled with position-independent mode (-fPIC), needlessly. 5) The upstream's documentation is installed, which adds no value - the texts are available online. 6) The bundled test-suit is not used. The proposed patch changes things thus: 1) Build and install the library using the bsd.lib.mk 2) Compile and run the author's regression.c 3) Patch the regression.c to work - not sure, why the patch is needed 4) Do not bother with the docs - these aren't man-pages and require a browser anyway, may as well read them online.