Bug 234350
| Summary: | [dtrace] Dtrace cannot print string arguments to system calls. | ||
|---|---|---|---|
| Product: | Base System | Reporter: | shamaz.mazum |
| Component: | bin | Assignee: | Mark Johnston <markj> |
| Status: | Closed FIXED | ||
| Severity: | Affects Only Me | CC: | rob2g2-freebsd |
| Priority: | --- | ||
| Version: | 12.0-RELEASE | ||
| Hardware: | Any | ||
| OS: | Any | ||
*** Bug 234352 has been marked as a duplicate of this bug. *** This might be a known regression fixed in r342053. Can you paste the first 20 lines of your dmesg here? (In reply to Mark Johnston from comment #2) This is output of dmesg. By the way, sorry for sending PR twice, I had networking problem. ---<<BOOT>>--- Copyright (c) 1992-2018 The FreeBSD Project. Copyright (c) 1979, 1980, 1983, 1986, 1988, 1989, 1991, 1992, 1993, 1994 The Regents of the University of California. All rights reserved. FreeBSD is a registered trademark of The FreeBSD Foundation. FreeBSD 12.0-RELEASE 952c9691f1b(release/12.0.0) MYKERNEL120 amd64 FreeBSD clang version 6.0.1 (tags/RELEASE_601/final 335540) (based on LLVM 6.0.1) VT(vga): resolution 640x480 CPU: AMD Ryzen 5 1600X Six-Core Processor (3593.34-MHz K8-class CPU) Origin="AuthenticAMD" Id=0x800f11 Family=0x17 Model=0x1 Stepping=1 Features=0x178bfbff<FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CLFLUSH,MMX,FXSR,SSE,SSE 2,HTT> Features2=0x7ed8320b<SSE3,PCLMULQDQ,MON,SSSE3,FMA,CX16,SSE4.1,SSE4.2,MOVBE,POPCNT,AESNI,XSAVE,OSXSAVE,AVX,F16C,RDRAN D> AMD Features=0x2e500800<SYSCALL,NX,MMX+,FFXSR,Page1GB,RDTSCP,LM> AMD Features2=0x35c233ff<LAHF,CMP,SVM,ExtAPIC,CR8,ABM,SSE4A,MAS,Prefetch,OSVW,SKINIT,WDT,TCE,Topology,PCXC,PNXC,DBE, PL2I,MWAITX> Structured Extended Features=0x209c01a9<FSGSBASE,BMI1,AVX2,SMEP,BMI2,RDSEED,ADX,SMAP,CLFLUSHOPT,SHA> XSAVE Features=0xf<XSAVEOPT,XSAVEC,XINUSE,XSAVES> AMD Extended Feature Extensions ID EBX=0x7<CLZERO,IRPerf,XSaveErPtr> SVM: NP,NRIP,VClean,AFlush,DAssist,NAsids=32768 TSC: P-state invariant, performance statistics real memory = 17179869184 (16384 MB) avail memory = 16557715456 (15790 MB) Your processor implements SMAP, so it is indeed affected. You can try applying this patch to your kernel to fix the problem: https://svnweb.freebsd.org/changeset/base/342267 I believe we will also release an errata notice and patch for 12.0, so you'll be able to use freebsd-update to fix the problem. Thank you very much! (In reply to Mark Johnston from comment #4) Update: the suggested patch seems to be working only partially. I can see strings passed from userspace, but there are also many errors like so: dtrace: error on enabled probe ID 1 (ID 77393: syscall:freebsd:openat:entry): invalid address (0xffffffffffffff9c) in action #2 at DIF offset 12 Seems like kernel space address, is it not? Also, it is always the same address (0xffffffffffffff9c). (In reply to shamaz.mazum from comment #6) Yes, that is expected. Note that the new errors are coming from syscall::openat:entry rather than syscall::open:entry. The first argument to openat(2) is a file descriptor, not a string. (In reply to Mark Johnston from comment #7) Oh, my bad. Thanks The issue is fixed in 12.0-p3. |
I try to execute Dtrace like so: dtrace -n 'syscall::open*:entry { printf("%s %s", execname, copyinstr(arg0)); }' and get some strange errors: dtrace: error on enabled probe ID 2 (ID 76423: syscall:freebsd:open:entry): invalid address (0x8002543a3) in action #2 at DIF offset 12 like when stringof() were used instead of copyinstr(). FreeBSD version 12.0-RELEASE.