Bug 234393
| Summary: | audio/pithos: Remove unnecessary git dependency | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Mark Linimon <linimon> | ||||
| Component: | Individual Port(s) | Assignee: | John Hixson <jhixson> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Some People | CC: | jhibbits | ||||
| Priority: | --- | Keywords: | needs-qa | ||||
| Version: | Latest | Flags: | jhixson:
maintainer-feedback+
|
||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Is the s/USE_GSTREAMER/USE_GSTREAMER11 change intentional? It's intentional, but unrelated to removing the git dependency. pithos really only uses gstreamer1 through the py-gstreamer interface, it does not use gstreamer0.10. See https://reviews.freebsd.org/D17197 for the change I had proposed a while back. LGTM A commit references this bug: Author: linimon Date: Sun Jan 13 21:45:03 UTC 2019 New revision: 490216 URL: https://svnweb.freebsd.org/changeset/ports/490216 Log: Remove unneccesary dependency on git. Switch to USE_GSTREAMER1. PR: 234393 Reported by: jhibbits Approved by: maintainer Changes: head/audio/pithos/Makefile |
Created attachment 200495 [details] patch to audio/pithos/Makefile audio/pithos depends on git, which seems uneccesary, and can cause a conflict for some users. Tested on amd64. Suggested by jhibbits.