Summary: | devel/aws-c-event-stream: fix build with GCC-based architectures | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Piotr Kubaj <pkubaj> | ||||
Component: | Individual Port(s) | Assignee: | Danilo Egea Gondolfo <danilo> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Only Me | CC: | linimon, pkubaj | ||||
Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(danilo) |
||||
Version: | Latest | ||||||
Hardware: | Any | ||||||
OS: | Any | ||||||
Attachments: |
|
This flag probably comes from /usr/local/lib/cmake/AwsCFlags.cmake. This file is intalled by devel/aws-c-commons. (In reply to Danilo Egea Gondolfo from comment #1) Yes, you're right. Do you want me to make a patch to remove this flag, or do you prefer to add USES=compiler:c11 to this port? Give me few days to work on it. There are other changes I want to do. A commit references this bug: Author: danilo Date: Sat Jan 12 18:36:40 UTC 2019 New revision: 490071 URL: https://svnweb.freebsd.org/changeset/ports/490071 Log: - Update to 0.1.1 - Add compiler:c11 to fix build on archs that still use GCC as default compiler [1] PR: 234401 Submitted by: Piotr Kubaj [1] Changes: head/devel/aws-c-event-stream/Makefile head/devel/aws-c-event-stream/distinfo head/devel/aws-c-event-stream/pkg-plist Committed. Thanks! |
Created attachment 200504 [details] patch Add USES=compiler:c11 to fix build on GCC architectures. This port should technically build with base GCC, but it adds -Wno-sign-conversion to CFLAGS, which is automatically added by ninja and isn't found anywhere in the source files by grepping them. Tested on powerpc64 and amd64. Hardware sponsored by IntegriCloud.